Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update monte_carlo.py #6

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SiboVG
Copy link
Member

@SiboVG SiboVG commented Feb 4, 2025

Motor configs are not detected. Create a simulation in openrocket file. Use pathways associated with your workflow in the py code.

Motor configs are not detected. Create a simulation in openrocket file. Use pathways associated with your workflow in the py code.
@SiboVG SiboVG marked this pull request as draft February 15, 2025 14:04
@SiboVG
Copy link
Member Author

SiboVG commented Feb 15, 2025

Note that this is a PR of @Ansley-Paul. The code contains problems, like using absolute file paths. I haven't looked into the code in any way, other than a quick glance.

@Ansley-Paul
Copy link

Ansley-Paul commented Feb 15, 2025

You can also configure the pathways using the steps that were given in the readme file of setup of orhelper instead, and those paths in my version of the code could just be commented out. The only path needed would be to the rocketry file that you are extracting information from, that would have to be specified in the code.
image

@Ansley-Paul
Copy link

My PR aims to debug the original code, and make the Monte Carlo Simulations run, which the original code does not do. There is only 1 issue in my main code: I have debugged everything except the motor configs that are not being detected by montecarlo.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants