Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically retrieve API spec yaml file from release asset #5305

Merged
merged 4 commits into from
Feb 6, 2025

Conversation

zelinh
Copy link
Member

@zelinh zelinh commented Feb 4, 2025

Description

Currently we are storing the API spec yaml file within opensearch-build repo. With more changes happened in opensearch-api-specification repo, it's hard to maintain and update each time.
For smoke tests, this PR is to dynamically download the API spec yaml file from opensearch-api-specification pre-release asset.

If downloading fails, use the existing spec file from build repo.

Issues Resolved

#5239

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.04%. Comparing base (f502e9d) to head (22a5cc2).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5305      +/-   ##
==========================================
- Coverage   92.06%   92.04%   -0.03%     
==========================================
  Files         202      202              
  Lines        7017     7036      +19     
==========================================
+ Hits         6460     6476      +16     
- Misses        557      560       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Zelin Hao <[email protected]>
@zelinh zelinh self-assigned this Feb 4, 2025
@zelinh zelinh added the enhancement New Enhancement label Feb 4, 2025
@zelinh zelinh merged commit ef8c3cf into opensearch-project:main Feb 6, 2025
15 checks passed
@zelinh zelinh deleted the smoke-test-api branch February 6, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants