-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate opendistro API paths #5102
Deprecate opendistro API paths #5102
Conversation
Signed-off-by: shikharj05 <[email protected]>
Signed-off-by: shikharj05 <[email protected]>
Signed-off-by: shikharj05 <[email protected]>
Signed-off-by: shikharj05 <[email protected]>
Signed-off-by: shikharj05 <[email protected]>
Signed-off-by: shikharj05 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5102 +/- ##
==========================================
+ Coverage 71.60% 71.65% +0.05%
==========================================
Files 335 335
Lines 22665 22731 +66
Branches 3598 3598
==========================================
+ Hits 16229 16288 +59
- Misses 4634 4641 +7
Partials 1802 1802
|
@shikharj05 The changes look good to me in this PR. What is remaining before taking it out of draft? |
I was blocked on #5053 for testing, will re-base, test couple of APIs and remove this out of draft. |
Moved to review state |
Description
[Describe what this change achieves]
Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation) Maintenance
Why these changes are required?
The security repo has lingering usages of the legacy terms like _opendistro is API paths, these are replaced with _plugins prefix, however legacy paths are not explicitly marked as deprecated.
What is the old behavior before changes and new behavior after changes?
If an API uses _opendistro as path, log a deprecation message.
e.g.
logs-
Issues Resolved
#5097
Is this a backport? If so, please add backport PR # and/or commits #, and remove
backport-failed
label from the original PR.Do these changes introduce new permission(s) to be displayed in the static dropdown on the front-end? If so, please open a draft PR in the security dashboards plugin and link the draft PR here
Testing
TODO
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.