Add explain ITs with Calcite wihtout pushdown #3786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuanchun Shen <[email protected]>
yuancu
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
mengweieric,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto,
GumpacG,
ykmr1224,
LantaoJin,
noCharger and
qianheng-aws
as code owners
dai-chen
reviewed
Jun 17, 2025
| private String loadExpectedPlan(String fileName) throws IOException { | ||
| String prefix; | ||
| if (isCalciteEnabled()) { | ||
| if (isPushdownEnabled()) { |
There was a problem hiding this comment.
In the future, just wonder in which case we may disable pushdown? Is this only for testing purpose?
There was a problem hiding this comment.
For testing purpose, we need to confirm all operations running in Calcite could meet our expects. We wouldn't disable pushdown config. But all operators should work as expected without pushdown. For example, filter operator can be pushdown in normal. But it cannot be pushdown after join operator.
LantaoJin
added
testing
LantaoJin
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Integration tests for
explaincommand with pushdown disabled in CalciteRelated Issues
Resolves #3785
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.