[BUG] Fix flaky tests related to WeekOfYear in CalcitePPLDateTimeBuiltinFunctionIT #3815
+40
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuanchun Shen <[email protected]>
yuancu
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
mengweieric,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto,
GumpacG,
ykmr1224,
LantaoJin,
noCharger and
qianheng-aws
as code owners
LantaoJin
approved these changes
Jun 24, 2025
LantaoJin
added
flaky-test
penghuo
approved these changes
Jun 26, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 26, 2025
…IT (#3815) Signed-off-by: Yuanchun Shen <[email protected]> (cherry picked from commit 30f2508) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes flaky tests related to
YEARWEEKfunction in certain locales.This fix assumes that the existing implementation is correct, and only fixes tests.
The problem arises from
sql/core/src/main/java/org/opensearch/sql/expression/datetime/CalendarLookup.java
Line 62 in b610ce9
When locale is in
ja-JP-u-ca-japanese-x-lvariant-JP, the calendar implementation isJapanImperialCalender. Retrieving week of the year with this calendar on 1984-04-12 results in 14; while inen-USlocale it returns 15.Related Issues
Resolves #3814
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.