Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'secure-boot-for-shielded-vms' flag to expose secureboot on GCP #583

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

JakobGray
Copy link
Contributor

Issue: https://issues.redhat.com/browse/OCM-4974

  • Adds --secure-boot-for-shielded-vms flag for enabling secure boot on GCP clusters.
  • Adds secureBoot field to cluster describe output (only when enabled)
  • Adds interactive prompt for secureBoot after multi-az (only for GCP)

Interactive view:

? Multiple AZ: No
? Secure Boot enables the use of Shielded VMs in the Google Cloud Platform.
? Secure boot support for Shielded VMs: (y/N) 

Create cluster help view:

Usage:
  ocm create cluster [flags] NAME

Flags:
      --secure-boot-for-shielded-vms                          Secure Boot enables the use of Shielded VMs in the Google Cloud Platform.

Cluster describe view:

ID:			27v4ri1ot49embn20k3qot1fspjoas6e
Multi-az:		false
SecureBoot:             true
CCS:			true

Copy link
Collaborator

@renan-campos renan-campos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ckandag
Copy link
Collaborator

ckandag commented Dec 7, 2023

/lgtm

1 similar comment
@hunterkepley
Copy link
Collaborator

/lgtm

@hunterkepley hunterkepley merged commit 4a7a4c6 into openshift-online:main Dec 7, 2023
4 checks passed
@JakobGray JakobGray deleted the OCM-4974 branch December 7, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants