Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace sign measures script by tools/benchmark.py #14

Merged
merged 4 commits into from
Mar 21, 2024
Merged

Replace sign measures script by tools/benchmark.py #14

merged 4 commits into from
Mar 21, 2024

Conversation

rh-rahulshetty
Copy link
Member

@rh-rahulshetty rh-rahulshetty commented Mar 20, 2024

Switch to benchmark.py script for capturing pipelinerun and taskruns signing status.

@openshift-ci openshift-ci bot requested review from jhutar and khrm March 20, 2024 12:04
@rh-rahulshetty rh-rahulshetty changed the title restored measure-signed.py script from old commit restore measure-signed.py script from old commit Mar 20, 2024
@siddardh-ra
Copy link

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Mar 20, 2024

@siddardh-ra: changing LGTM is restricted to collaborators

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rh-rahulshetty rh-rahulshetty changed the title restore measure-signed.py script from old commit Replace sign measures script by tools/benchmark.py Mar 21, 2024
Copy link
Contributor

@jhutar jhutar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

openshift-ci bot commented Mar 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhutar, rh-rahulshetty, siddardh-ra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jhutar jhutar merged commit 27201da into openshift-pipelines:main Mar 21, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants