CNTRLPLANE-72: remove RoleBindingRestriction CRD from payload #2138
Conversation
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Hello @everettraven! Some important instructions when contributing to openshift/api: |
openshift-ci
bot
added
the
size/L
|
This needs to wait until we have the changes in place on the cluster-authentication-operator to start managing the CRD. /hold |
openshift-ci
bot
added
the
do-not-merge/hold
everettraven
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@everettraven: This pull request references CNTRLPLANE-72 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@everettraven: This pull request references CNTRLPLANE-72 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
|
/lgtm |
|
/retest |
|
openshift/cluster-authentication-operator#748 and openshift/installer#9424 have merged. This should be good to go as long as tests are happy. /hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
cc @JoelSpeed for whenever you have time to take a look. This is part of moving the management of the RoleBindingRestriction CRD to the cluster-authentication-operator. Outlined in openshift/enhancements#1726 |
|
/approve |
openshift-ci
bot
added
the
approved
2 similar comments
|
Retest will likely fail here 🤦 - openshift/hypershift#6137 merged less than an hour ago and is likely not in a CI payload build yet. Will re-trigger the tests again when a new CI payload including the change has been built and approved |
|
/retest |
|
Looks like the most recent runs with hypershift passed. Removing hold. /hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
openshift-merge-robot
added
the
needs-rebase
so that it can be managed by the cluster-authentication-operator instead of cluster-version-operator. This enables the cluster-authentication-operator to remove the CRD from the cluster when OIDC authentication is configured. Signed-off-by: Bryce Palmer <[email protected]>
everettraven
force-pushed
the
remove-rbr-crd-from-payload
branch
from
bb85ed6 to
eda0c6a
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/lgtm |
1 similar comment
Signed-off-by: Bryce Palmer <[email protected]>
|
/retest-required |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: everettraven, JoelSpeed, liouk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
2 similar comments
|
@everettraven: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
so that it can be managed by the cluster-authentication-operator instead of cluster-version-operator. This enables the cluster-authentication-operator to remove the CRD from the cluster when intentionally taking down the OpenShift OAuth stack.