Skip to content

[release-4.18]: add OnClusterBuilds to default config #2365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release-4.18
Choose a base branch
from

Conversation

cheesesashimi
Copy link
Member

This effectively makes OnClusterBuild no longer require TechPreviewNoUpgrade to be enabled before making use of this feature in 4.18.z. Similar work has already landed in 4.19.

Copy link
Contributor

openshift-ci bot commented Jun 12, 2025

Hello @cheesesashimi! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 12, 2025
Copy link
Contributor

openshift-ci bot commented Jun 12, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 12, 2025
@cheesesashimi cheesesashimi changed the title add OnClusterBuilds to default config [release-4.18]: add OnClusterBuilds to default config Jun 12, 2025
Copy link
Contributor

openshift-ci bot commented Jun 12, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cheesesashimi
Once this PR has been reviewed and has the lgtm label, please assign derekwaynecarr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cheesesashimi cheesesashimi marked this pull request as ready for review June 12, 2025 19:45
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 12, 2025
@openshift-ci openshift-ci bot requested review from deads2k and jkyros June 12, 2025 19:45
@sergiordlr
Copy link

Verified using IPI on AWS

All MCO e2e OCB test cases pased

@cheesesashimi
Copy link
Member Author

/test e2e-gcp

Copy link
Contributor

openshift-ci bot commented Jun 18, 2025

@cheesesashimi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify-crd-schema 34bde19 link true /test verify-crd-schema
ci/prow/okd-scos-e2e-aws-ovn 34bde19 link false /test okd-scos-e2e-aws-ovn
ci/prow/verify 34bde19 link true /test verify
ci/prow/e2e-gcp 34bde19 link false /test e2e-gcp

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants