MCO-1764: Validation expression for Template in VSphereMachineProviderSpec #2374
Conversation
|
Hello @RishabhSaini! Some important instructions when contributing to openshift/api: |
openshift-ci
bot
added
the
size/XS
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: RishabhSaini The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
RishabhSaini
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@RishabhSaini: This pull request references MCO-1764 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@RishabhSaini: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@RishabhSaini The API you've updated isn't actually a CRD, but is used as part of a raw extension. This means the validation is implemented in a webhook. While I think adding this here helps in terms of documentation, realistically it needs to be implemented in a ratcheting way in https://github.com/openshift/machine-api-operator/blob/b9b1512b4263bf6e36c7b6a81d155f0fb944b3c2/pkg/webhooks/machine_webhook.go#L1494 |
| @@ -23,6 +23,7 @@ type VSphereMachineProviderSpec struct { | |||
| CredentialsSecret *corev1.LocalObjectReference `json:"credentialsSecret,omitempty"` | |||
| // template is the name, inventory path, or instance UUID of the template | |||
| // used to clone new machines. | |||
| // +kubebuilder:validation:MaxLength=80 | |||
There was a problem hiding this comment.
The virtual machine name is 80 characters max in length but this field afaik is the path to the virtual machine which would most likely always be greater than 80 characters
cc: @vr4manta
There was a problem hiding this comment.
do we have a limit on this that can be imposed?
Since Template refers to a VM template name, vSphere has a limit set to 80 characters. Hence enforcing this on an API level helps prevent failures post ProviderSpec application