Skip to content

[release-4.19] MCO-1766: Promote PinnedImageSets feature gate to default #2377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release-4.19
Choose a base branch
from

Conversation

RishabhSaini
Copy link
Contributor

This promotes the PinnedImageSet feature gate to Default in the 4.19

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 20, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 20, 2025

@RishabhSaini: This pull request references MCO-1766 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

This promotes the PinnedImageSet feature gate to Default in the 4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Jun 20, 2025

Hello @RishabhSaini! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 20, 2025
@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 20, 2025
@openshift-ci openshift-ci bot requested review from everettraven and jkyros June 20, 2025 16:28
Copy link
Contributor

openshift-ci bot commented Jun 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: RishabhSaini
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RishabhSaini RishabhSaini changed the base branch from master to release-4.19 June 20, 2025 16:29
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 20, 2025

@RishabhSaini: This pull request references MCO-1766 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

This promotes the PinnedImageSet feature gate to Default in the 4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Jun 20, 2025

@RishabhSaini: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-hypershift 36a5bac link true /test e2e-aws-ovn-hypershift
ci/prow/e2e-azure 36a5bac link false /test e2e-azure
ci/prow/e2e-aws-serial-techpreview-1of2 36a5bac link true /test e2e-aws-serial-techpreview-1of2
ci/prow/verify-crd-schema 36a5bac link true /test verify-crd-schema
ci/prow/e2e-aws-serial-techpreview-2of2 36a5bac link true /test e2e-aws-serial-techpreview-2of2
ci/prow/unit 36a5bac link true /test unit
ci/prow/integration 36a5bac link true /test integration
ci/prow/e2e-upgrade-out-of-change 36a5bac link true /test e2e-upgrade-out-of-change
ci/prow/e2e-aws-ovn-hypershift-conformance 36a5bac link true /test e2e-aws-ovn-hypershift-conformance
ci/prow/build 36a5bac link true /test build
ci/prow/verify-feature-promotion 36a5bac link true /test verify-feature-promotion
ci/prow/minor-images 36a5bac link true /test minor-images
ci/prow/e2e-aws-serial-1of2 36a5bac link true /test e2e-aws-serial-1of2
ci/prow/verify 36a5bac link true /test verify
ci/prow/minor-e2e-upgrade-minor 36a5bac link true /test minor-e2e-upgrade-minor
ci/prow/e2e-aws-ovn-techpreview 36a5bac link true /test e2e-aws-ovn-techpreview
ci/prow/e2e-upgrade 36a5bac link true /test e2e-upgrade
ci/prow/verify-deps 36a5bac link true /test verify-deps
ci/prow/verify-feature-promotion 36a5bac link true /test verify-feature-promotion
ci/prow/lint 36a5bac link true /test lint
ci/prow/e2e-gcp 36a5bac link false /test e2e-gcp
ci/prow/okd-scos-e2e-aws-ovn 36a5bac link false /test okd-scos-e2e-aws-ovn
ci/prow/images 36a5bac link true /test images
ci/prow/verify-client-go 36a5bac link true /test verify-client-go
ci/prow/e2e-aws-serial-2of2 36a5bac link true /test e2e-aws-serial-2of2
ci/prow/e2e-aws-ovn 36a5bac link true /test e2e-aws-ovn
ci/prow/verify-crd-schema 36a5bac link true /test verify-crd-schema

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants