Skip to content

[WIP] STOR-2465: Add ExternalSnapshotMetadata CRD #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dobsonj
Copy link
Member

@dobsonj dobsonj commented Jun 23, 2025

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 23, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 23, 2025

@dobsonj: This pull request references STOR-2465 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.20.0" version, but no target version was set.

In response to this:

https://issues.redhat.com/browse/STOR-2465

/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Jun 23, 2025

@dobsonj: GitHub didn't allow me to request PR reviews from the following users: openshift/storage.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

https://issues.redhat.com/browse/STOR-2465

/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 23, 2025

@dobsonj: This pull request references STOR-2465 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.20.0" version, but no target version was set.

In response to this:

https://issues.redhat.com/browse/STOR-2465
Depends on openshift/api#2381

/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dobsonj dobsonj changed the title STOR-2465: Add ExternalSnapshotMetadata CRD [WIP] STOR-2465: Add ExternalSnapshotMetadata CRD Jun 23, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 23, 2025
Copy link
Contributor

openshift-ci bot commented Jun 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2025
Copy link
Contributor

openshift-ci bot commented Jun 24, 2025

@dobsonj: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere b15099b link true /test e2e-vsphere
ci/prow/e2e-aws b15099b link true /test e2e-aws
ci/prow/okd-scos-e2e-aws-ovn b15099b link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-vsphere-csi b15099b link true /test e2e-vsphere-csi
ci/prow/e2e-gcp-csi b15099b link true /test e2e-gcp-csi
ci/prow/e2e-hypershift-conformance b15099b link false /test e2e-hypershift-conformance
ci/prow/e2e-upgrade b15099b link true /test e2e-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dobsonj
Copy link
Member Author

dobsonj commented Jun 24, 2025

simple manual test with cluster-bot launch 4.20.0-0.ci,openshift/api#2381,openshift/cluster-csi-snapshot-controller-operator#239 azure:

$ oc get crd | grep -i snapshotmetadataservice
$ oc edit featuregate cluster
featuregate.config.openshift.io/cluster edited
$ oc get featuregate cluster -o json | jq .spec
{
  "featureSet": "DevPreviewNoUpgrade"
}
$ oc get crd | grep -i snapshotmetadataservice
snapshotmetadataservices.cbt.storage.k8s.io                       2025-06-24T17:55:55Z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants