Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-48673: targetconfigcontroller: check live etcd endpoints #1792

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

OCPBUGS-48673: targetconfigcontroller: check live etcd endpoints #1792

wants to merge 1 commit into from
+202 −38

Conversation

dgrisonnet
Copy link
Member

@dgrisonnet dgrisonnet commented Jan 27, 2025 •
edited
Loading

Compare the etcd-servers list of URLs to the list of endpoints exposed
by cluster-etcd-operator to make sure that the kube-apiserver config has
at least two endpoints that are not localhost and bootstrap to satisfy
HA requirements.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 27, 2025
@openshift-ci openshift-ci bot requested review from deads2k and hasbro17 January 27, 2025 18:50
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2025
@dgrisonnet dgrisonnet force-pushed the check-etcd-endpoints branch from ccf85d7 to 2c13875 Compare January 28, 2025 15:19
@dgrisonnet dgrisonnet changed the title WIP: pkg/operator: add revision precondition on etcd endpoints OCPBUGS-48673: pkg/operator: add revision precondition on etcd endpoints Jan 28, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 28, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 28, 2025
@openshift-ci-robot
Copy link

@dgrisonnet: This pull request references Jira Issue OCPBUGS-48673, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Testing what would happen if we were to gate new revision on the number of available etcd endpoints exposed by ceo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dgrisonnet dgrisonnet changed the title OCPBUGS-48673: pkg/operator: add revision precondition on etcd endpoints OCPBUGS-48673: targetconfigcontroller: check live etcd endpoints Jan 28, 2025
@dgrisonnet dgrisonnet force-pushed the check-etcd-endpoints branch from 2c13875 to c2e7a5b Compare January 28, 2025 18:11
@dgrisonnet
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 28, 2025
@openshift-ci-robot
Copy link

@dgrisonnet: This pull request references Jira Issue OCPBUGS-48673, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @wangke19

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from wangke19 January 28, 2025 18:55
@dgrisonnet
targetconfigcontroller: check live etcd endpoints
e32cbb3 
Compare the etcd-servers list of URLs to the list of endpoints exposed
by cluster-etcd-operator to make sure that the kube-apiserver config has
at least two endpoints that are not localhost and bootstrap to satisfy
HA requirements.

Signed-off-by: Damien Grisonnet <[email protected]>
@dgrisonnet dgrisonnet force-pushed the check-etcd-endpoints branch from c2e7a5b to e32cbb3 Compare January 28, 2025 19:01
@dgrisonnet
Copy link
Member Author

Failures seem unrelated

/retest-required

@dgrisonnet
Copy link
Member Author

/retest

@dgrisonnet
Copy link
Member Author

/retest-required

1 similar comment
@dgrisonnet
Copy link
Member Author

/retest-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 30, 2025 •
edited
Loading

@dgrisonnet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-operator-single-node e32cbb3 link false /test e2e-gcp-operator-single-node
ci/prow/e2e-aws-operator-disruptive-single-node e32cbb3 link false /test e2e-aws-operator-disruptive-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dgrisonnet
Copy link
Member Author

/retest-required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@hasbro17 hasbro17 Awaiting requested review from hasbro17

@wangke19 wangke19 Awaiting requested review from wangke19

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dgrisonnet @openshift-ci-robot