Skip to content

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
vojtechszocs committed Apr 9, 2024
1 parent e1cf3c5 commit 686e7f4
Show file tree
Hide file tree
Showing 2 changed files with 31 additions and 26 deletions.
53 changes: 29 additions & 24 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
@@ -1,26 +1,31 @@
{
"name": "Console + Dynamic Plugin",
"dockerComposeFile": "docker-compose.yml",
"service": "plugin",
"workspaceFolder": "/workspace",
"settings": {},
"initializeCommand": ".devcontainer/init.sh",
"postCreateCommand": "yarn && eval 'oc login $OC_URL -u $OC_USER -p $OC_PASS --insecure-skip-tls-verify'",
"forwardPorts": [9000,9001],
"portsAttributes": {
"9000": {
"label": "Console",
},
"9001": {
"label": "Plugin static files",
"onAutoForward": "silent"
}
},
"features": {},
"extensions": [
"ms-azuretools.vscode-docker",
"ms-vscode.vscode-typescript-next",
"dbaeumer.vscode-eslint",
"esbenp.prettier-vscode",
],
"name": "Console + Plugin",
"dockerComposeFile": "docker-compose.yml",
"service": "plugin",
"workspaceFolder": "/workspace",

"initializeCommand": ".devcontainer/init.sh",
"postCreateCommand": "yarn && eval 'oc login $OC_URL -u $OC_USER -p $OC_PASS --insecure-skip-tls-verify'",
"forwardPorts": [9000, 9001],
"portsAttributes": {
"9000": {
"label": "Console"
},
"9001": {
"label": "Plugin static files",
"onAutoForward": "silent"
}
},
"features": {},
"customizations": {
"vscode": {
"settings": {},
"extensions": [
"ms-azuretools.vscode-docker",
"ms-vscode.vscode-typescript-next",
"dbaeumer.vscode-eslint",
"esbenp.prettier-vscode"
]
}
}
}
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "console-plugin-template",
"version": "0.0.1",
"description": "Template project for OpenShift Console dynamic plugins",
"description": "Template project for OpenShift Console plugins",
"private": true,
"license": "Apache-2.0",
"repository": {
Expand Down Expand Up @@ -72,7 +72,7 @@
"name": "console-plugin-template",
"version": "0.0.1",
"displayName": "OpenShift Console Plugin Template",
"description": "Template project for OpenShift Console dynamic plugins. Edit package.json to change this message and the plugin name.",
"description": "Template project for OpenShift Console plugins. Edit package.json to change this message and the plugin name.",
"exposedModules": {
"ExamplePage": "./components/ExamplePage"
},
Expand Down

0 comments on commit 686e7f4

Please sign in to comment.