CONSOLE-4445: Upgrade console-plugin-template to PatternFly 6 #74
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhamilto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Hey, @rhamilto. Let's discuss how we want to time this. I suspect most people authoring new plugins will use master, which won't work until 4.19 ships. There is the release-4.18 branch they can use, though. Minimally, we'd want to document this better in the README and probably OpenShift docs. |
|
@rhamilto: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
jhadvig
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
jira/valid-reference
|
@rhamilto: This pull request references CONSOLE-4445 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| "@patternfly/react-core": "^5.1.1", | ||
| "@patternfly/react-icons": "^5.1.1", | ||
| "@patternfly/react-styles": "^5.1.1", | ||
| "@patternfly/react-core": "^6.1.1-prerelease.1", |
There was a problem hiding this comment.
Should be changed to same versions as console as part of https://issues.redhat.com/browse/CONSOLE-4464
|
@rhamilto: This pull request references CONSOLE-4445 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
LGTM but I'd prefer to wait until we have PF/React packages in the right versions, i.e. avoid using prerelease packages. |
And we should wait until we're closer to 4.20 branching as well. |
|
This PR has been verified,and no layout issue was found, the code can be built without any issue |
openshift-ci
bot
added
the
qe-approved
|
@rhamilto: This pull request references CONSOLE-4445 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold until closer to 4.20 branching (scheduled for April 18, 2025) |
openshift-ci
bot
added
the
do-not-merge/hold
No description provided.