OCPBUGS-41879: vSphere - if regions are the same cannot dup zones

[jcpowermac]

If the vsphere failure domain region names are the same across multiples the zones cannot be duplicated.
This commit adds this validation and unit tests.

[openshift-ci-robot]

@jcpowermac: This pull request references Jira Issue OCPBUGS-41879, which is invalid:

• expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

If the vsphere failure domain region names are the same across multiples the zones cannot be duplicated.
This commit adds this validation and unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jcpowermac]

/jira refresh

[openshift-ci-robot]

@jcpowermac: This pull request references Jira Issue OCPBUGS-41879, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.20.0) matches configured target version for branch (4.20.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@jcpowermac: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-vsphere-ovn-hybrid-env	12186d3	link	false	/test e2e-vsphere-ovn-hybrid-env
ci/prow/okd-scos-e2e-aws-ovn	12186d3	link	false	/test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[tthvo]

/lgtm

[jcpowermac]

/retest-required

[vr4manta]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vr4manta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/types/vsphere/validation/OWNERS [vr4manta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 376af3a and 2 for PR HEAD 12186d3 in total

[openshift-ci-robot]

@jcpowermac: Jira Issue OCPBUGS-41879: All pull requests linked via external trackers have merged:

• openshift/installer#9787

Jira Issue OCPBUGS-41879 has been moved to the MODIFIED state.

In response to this:

If the vsphere failure domain region names are the same across multiples the zones cannot be duplicated.
This commit adds this validation and unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.