Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPNODE-2875: skip drain on new registry entry without mirrors #4816

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

QiWang19
Copy link
Member

@QiWang19 QiWang19 commented Jan 28, 2025

- What I did
openshift/runtime-utils#22 allows adding a new registry entry to registries.conf without using a mirror through ICSP, IDMS, or ITMS. The MirrorByDigestOnly setting does not affect image pulls from the primary registry with this new registry change.(openshift/runtime-utils#22 (comment)) Therefore, this PR removes the logic that caused node drain in this scenario.
- How to verify it

- Description for the changelog

@openshift-ci openshift-ci bot requested review from djoshy and umohnani8 January 28, 2025 18:17
Copy link
Contributor

openshift-ci bot commented Jan 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: QiWang19
Once this PR has been reviewed and has the lgtm label, please assign djoshy for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Jan 28, 2025

@QiWang19: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn-upi 1074f59 link false /test e2e-vsphere-ovn-upi
ci/prow/e2e-azure-ovn-upgrade-out-of-change 1074f59 link false /test e2e-azure-ovn-upgrade-out-of-change
ci/prow/e2e-hypershift 1074f59 link true /test e2e-hypershift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@QiWang19 QiWang19 changed the title skip drain on new registry entry without mirrors OCPNODE-2875: skip drain on new registry entry without mirrors Feb 7, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 7, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 7, 2025

@QiWang19: This pull request references OCPNODE-2875 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

- What I did
openshift/runtime-utils#22 allows adding a new registry entry to registries.conf without using a mirror through ICSP, IDMS, or ITMS. The MirrorByDigestOnly setting does not affect image pulls from the primary registry with this new registry change. Therefore, this PR removes the logic that caused node drain in this scenario.
- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 7, 2025

@QiWang19: This pull request references OCPNODE-2875 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

- What I did
openshift/runtime-utils#22 allows adding a new registry entry to registries.conf without using a mirror through ICSP, IDMS, or ITMS. The MirrorByDigestOnly setting does not affect image pulls from the primary registry with this new registry change.(openshift/runtime-utils#22 (comment)) Therefore, this PR removes the logic that caused node drain in this scenario.
- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants