OCPBUGS-47743: Update cluster-reader ClusterRole permissions

[isabella-janssen]

- What I did

• Update the cluster-reader ClusterRole to have read-only permissions (get, list, and watch).

- How to verify it
Testing permission updates:

1. Use this PR to launch a cluster.
2. View the cluster-reader permissions in the Openshift UI by going to User Management → Roles → cluster-reader

Testing that functionality remained unchanged:

• Tests pass
• The cluster-reader permissions for the machineconfignodes resource were originally updated in OCPBUGS-24416: Sync MCN with node creation and deletion #4062, so I tested that this permission change did not re-introduce the bug fixed in that PR.
• This updates the permissions for the machineosconfigsand machineosbuilds resouces, so general OCL functionality was tested.
• Test that updates to Prometheus metrics originally introduced in MCO-407: add support for operator metrics #3537 still work as intended with updated auth permissions.

- Description for the changelog
OCPBUGS-47743: Update cluster-reader ClusterRole permissions

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[isabella-janssen]

/test all

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: isabella-janssen
Once this PR has been reviewed and has the lgtm label, please assign yuqi-zhang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@isabella-janssen: This pull request references Jira Issue OCPBUGS-47743, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.0) matches configured target version for branch (4.19.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

- What I did

• Update the cluster-reader ClusterRole to have read-only permissions (get, list, and watch).

- How to verify it
Testing permission updates:

1. Use this PR to launch a cluster.
2. View the cluster-reader permissions in the Openshift UI by going to User Management → Roles → cluster-reader

Testing that functionality remained unchanged:

• Tests pass
• The cluster-reader permissions for the machineconfignodes resource were originally updated in OCPBUGS-24416: Sync MCN with node creation and deletion #4062, so I tested that this permission change did not re-introduce the bug fixed in that PR.
• This updates the permissions for the machineosconfigsand machineosbuilds resouces, so general OCL functionality was tested.

- Description for the changelog
OCPBUGS-47743: Update cluster-reader ClusterRole permissions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[isabella-janssen]

/retest-required

[sergiordlr]

Critical mcoqe e2e test cases execution:
https://qe-private-deck-ci.apps.ci.l2s4.p1.openshiftapps.com/view/gs/qe-private-deck/logs/periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-aws-ipi-longduration-mco-critical-f9/1886349988066234368

Checked that no "delete" "update" or "patch" verbs are used in the cluster-reader clusterrole

$ oc get clusterrole cluster-reader  -oyaml  | grep delete
$ oc get clusterrole cluster-reader  -oyaml  | grep update
    rbac.authorization.kubernetes.io/autoupdate: "true"
$ oc get clusterrole cluster-reader  -oyaml  | grep patch

[openshift-ci-robot]

@isabella-janssen: This pull request references Jira Issue OCPBUGS-47743, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.0) matches configured target version for branch (4.19.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

In response to this:

- What I did

• Update the cluster-reader ClusterRole to have read-only permissions (get, list, and watch).

- How to verify it
Testing permission updates:

1. Use this PR to launch a cluster.
2. View the cluster-reader permissions in the Openshift UI by going to User Management → Roles → cluster-reader

Testing that functionality remained unchanged:

• Tests pass
• The cluster-reader permissions for the machineconfignodes resource were originally updated in OCPBUGS-24416: Sync MCN with node creation and deletion #4062, so I tested that this permission change did not re-introduce the bug fixed in that PR.
• This updates the permissions for the machineosconfigsand machineosbuilds resouces, so general OCL functionality was tested.
• Test that updates to metrics collection originally introduced in MCO-407: add support for operator metrics #3537 still work as intended with updated auth permissions.

- Description for the changelog
OCPBUGS-47743: Update cluster-reader ClusterRole permissions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[sergiordlr]

MCO critical test cases passed and the permissions in the clusterrole were fixed.

/label qe-approved

[openshift-ci]

@isabella-janssen: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	88813e2	link	false	/test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.