OCPBUGS-48469: Fix CoreDNS static pod bring-up on cloud platforms #4830
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sadasu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sadasu
changed the title
sadasu
force-pushed
the
fix-cloud-platform-corefile
branch
2 times, most recently
from
71cc2fd to
34e381d
Compare
sadasu
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
sadasu
changed the title
openshift-ci-robot
added
jira/severity-critical
|
@sadasu: This pull request references Jira Issue OCPBUGS-48469, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
sadasu
force-pushed
the
fix-cloud-platform-corefile
branch
2 times, most recently
from
513164e to
1bb98dc
Compare
sadasu
changed the title
|
/label acknowledge-critical-fixes-only |
openshift-ci
bot
added
the
acknowledge-critical-fixes-only
|
/retest |
| // If this is a cloud platform with DNSType set to `ClusterHosted` with | ||
| // LB IPs provided, include path for their CoreDNS files | ||
| if cloudPlatformLoadBalancerIPState(*config) == availableLBIPState { | ||
| platformBasedPaths = append(platformBasedPaths, cloudPlatformAltDNS) |
There was a problem hiding this comment.
Before this, was anything processing the templates in cloud-platform-alt-dns ? Was is being done in bootstrap only?
There was a problem hiding this comment.
It was being done on the Bootstrap node successfully and while debugging for the CoreDNS pod not starting on the master nodes, I found this issue.
|
/retest-required |
|
|
sadasu
force-pushed
the
fix-cloud-platform-corefile
branch
from
1bb98dc to
3a4599e
Compare
| - "--resolvconf-path" | ||
| - "/var/run/NetworkManager/resolv.conf" |
There was a problem hiding this comment.
Why? Isn't passing /etc/resolv.conf enough?
We do it in Metal in case you run a scenario where /etc/resolv.conf is not ready when we run. But I don't see yet how you could have a cloud VM that does not have any DNS server configured at startup
There was a problem hiding this comment.
I think /etc/resolv.conf is sufficient. I was going to ask you why /var/run/NetworkManager/resolv.conf was chosen for metal platform. Thanks for clarifying.
sadasu
changed the title
Fix issues with CoreDNS Corefile and template path for cloud platforms when UserProvisionedDNS is enabled. Pass in the optional parameter `--resolvconf-path` to the render method in baremetal-runtimecfg for cloud platforms too. The resolv.conf file would be used to populate `DNSUpstreams` in the Corefile template.
Also add test_data containing ControllerConfig for GCP when DNStype is `ClusterHosted` and all the LB IP values are available.
sadasu
force-pushed
the
fix-cloud-platform-corefile
branch
from
60b714b to
0060c15
Compare
|
@sadasu: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Fixes: OCPBUGS-48469
- What I did
- How to verify it
Set
UserProvisionedDNStoEnabledfor GCP via install-config and start installation- Description for the changelog
Fixed issues with CoreDNS Corefile and template path for cloud platforms when UserProvisionedDNS is enabled.
Added test_data for GCP with all the UserProvisionedDNS configuration to better test this path.