OCPBUGS-49894: Ensure proxy config exists when reverting from OCL to non-OCL

[cheesesashimi]

- What I did

I added the proxy config to the revert systemd service that gets written whenever one reverts from OCL to non-OCL. This is needed for the same reason that the revert systemd mechanism is; after rebooting into the factory OS, all of the configs are gone and the node effectively needs to be re-bootstrapped. While this works, the proxy config was not being recognized since it was effectively not there.

Additionally, this moves file management for all of the files needed into the RevertService implementation and outputs these files as part of the Ignition config that gets written to disk. This consolidates that process and makes things a bit easier to reason about.

Note: This PR is based upon #4825, which must land before this PR does.

- How to verify it

1. Bring up a cluster with OCL and a proxy config.
2. Create a MachineOSConfig for a given pool and wait for the build to complete.
3. Once the build is complete, label a node so that it joins the OCL-enabled pool.
4. Once the node has rebooted into the OCL image, move the node back to the non-OCL-enabled pool.
5. The node should revert back to the non-OCL configuration.

- Description for the changelog
Ensure proxy config exists when reverting from OCL to non-OCL

[openshift-ci-robot]

@cheesesashimi: This pull request references Jira Issue OCPBUGS-49894, which is invalid:

• expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

- What I did

I added the proxy config to the revert systemd service that gets written whenever one reverts from OCL to non-OCL. This is needed for the same reason that the revert systemd mechanism is; after rebooting into the factory OS, all of the configs are gone and the node effectively needs to be re-bootstrapped. While this works, the proxy config was not being recognized since it was effectively not there.

Additionally, this moves file management for all of the files needed into the RevertService implementation and outputs these files as part of the Ignition config that gets written to disk. This consolidates that process and makes things a bit easier to reason about.

Note: This PR is based upon #4825, which must land before this PR does.

- How to verify it

1. Bring up a cluster with OCL and a proxy config.
2. Create a MachineOSConfig for a given pool and wait for the build to complete.
3. Once the build is complete, label a node so that it joins the OCL-enabled pool.
4. Once the node has rebooted into the OCL image, move the node back to the non-OCL-enabled pool.
5. The node should revert back to the non-OCL configuration.

- Description for the changelog
Ensure proxy config exists when reverting from OCL to non-OCL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheesesashimi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cheesesashimi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@cheesesashimi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-vsphere-ovn-upi	3112f68	link	false	/test e2e-vsphere-ovn-upi
ci/prow/e2e-gcp-op	3112f68	link	true	/test e2e-gcp-op
ci/prow/e2e-azure-ovn-upgrade-out-of-change	3112f68	link	false	/test e2e-azure-ovn-upgrade-out-of-change
ci/prow/e2e-vsphere-ovn-upi-zones	3112f68	link	false	/test e2e-vsphere-ovn-upi-zones

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.