Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FLs and TLs as approvers #119

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

mmazur
Copy link
Member

@mmazur mmazur commented Oct 30, 2024

Make FLs and TLs approvers for cases where standard approvers aren't suitable/are hard to reach.

Ref OSD-25197

Copy link
Contributor

openshift-ci bot commented Oct 30, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mmazur
Once this PR has been reviewed and has the lgtm label, please assign nautilux for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.11%. Comparing base (4c15609) to head (1aa02d3).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #119   +/-   ##
=======================================
  Coverage   52.11%   52.11%           
=======================================
  Files           4        4           
  Lines         236      236           
=======================================
  Hits          123      123           
  Misses         93       93           
  Partials       20       20           

@mmazur
Copy link
Member Author

mmazur commented Nov 4, 2024

/test validate

Copy link
Contributor

openshift-ci bot commented Nov 4, 2024

@mmazur: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/validate 1aa02d3 link true /test validate

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants