MULTIARCH-5058: Implement the node affinity scoring specs in the ClusterPodPlacementConfig #369

pkenchap · 2024-11-20T05:12:39Z

Task to add the nodeAffinityScoring for ClusterPodPlacemetnConfig API specs can be updated as in the following to host a skeleton of plugins, currently implementing only the nodeAffinityScoring.

Example:

spec:
  plugins:
    nodeAffinityScoring:
        enabled: true
        platforms:
            - architecture: amd64
              # os: linux # TODO: this structure can support the os field in the future (e.g., for win containers)
              weight: 100

openshift-ci-robot · 2024-11-20T05:12:44Z

@pkenchap: This pull request references MULTIARCH-5058 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Task to add the nodeAffinityScoring for ClusterPodPlacemetnConfig API specs can be updated as in the following to host a skeleton of plugins, currently implementing only the nodeAffinityScoring.

Example:
spec:
 plugins:
   nodeAffinityScoring:
       enabled: true
       platforms:
           - architecture: amd64
             # os: linux # TODO: this structure can support the os field in the future (e.g., for win containers)
             weight: 100

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

pkenchap · 2024-11-20T05:13:08Z

/assign @pkenchap

apis/multiarch/common/plugins/plugins.go

apis/multiarch/v1beta1/clusterpodplacementconfig_types.go

apis/multiarch/common/plugins/plugins.go

apis/multiarch/common/plugins/nodeaffinityscoring_plugin.go

apis/multiarch/v1alpha1/clusterpodplacementconfig_types.go

apis/multiarch/v1beta1/clusterpodplacementconfig_types.go

bundle/manifests/multiarch-tuning-operator.clusterserviceversion.yaml

bundle/manifests/multiarch.openshift.io_clusterpodplacementconfigs.yaml

config/crd/bases/multiarch.openshift.io_clusterpodplacementconfigs.yaml

apis/multiarch/common/plugins/nodeaffinityscoring_plugin.go

bundle/manifests/multiarch.openshift.io_clusterpodplacementconfigs.yaml

prb112 · 2024-12-02T20:26:28Z

config/samples/nodeaffinityscoring/kustomization.yaml

@@ -0,0 +1,5 @@
+## Append samples you want in your CSV to this file as resources ##
+resources:
+- multiarch_v1beta1_nodeaffinityscoring_clusterpodplacementconfig.yaml


I don't think you need this in a subfolder

I'm still not getting the point of this customization.... is it autogenerated?

+1, we do not need this example.

ok sure , I can remove this .

Can we remove this and solve this comment to start wrapping up?

...les/nodeaffinityscoring/multiarch_v1beta1_nodeaffinityscoring_clusterpodplacementconfig.yaml

aleskandro · 2025-02-05T10:09:48Z

controllers/podplacement/plugins_test.go

+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			plugin := &plugins.BasePlugin{Enabled: tt.enabled}
+			if plugin.IsEnabled() != tt.expected {


Suggested change

if plugin.IsEnabled() != tt.expected {

if plugin.IsEnabled() != tt.enabled {

This unit test concers the correcteness of the IsEnabled function. Given the simplicity, it's ok not to duplicate the expected value and use tt.enabled.

aleskandro · 2025-02-05T10:10:56Z

apis/multiarch/v1alpha1/clusterpodplacementconfig_types.go

+
+	// Plugins selects the namespaces where the pod placement operand can process the nodeAffinityScoring
+	// of the pods. If left empty, all the namespaces are considered.
+	// The default sample allows to exclude all the namespaces where the
+	// +optional
+	Plugins plugins.Plugins `json:"plugins,omitempty"`


Suggested change

// Plugins selects the namespaces where the pod placement operand can process the nodeAffinityScoring

// of the pods. If left empty, all the namespaces are considered.

// The default sample allows to exclude all the namespaces where the

// +optional

Plugins plugins.Plugins `json:"plugins,omitempty"`

We should not update the v1alpha1 api.

pkenchap · 2025-02-06T08:34:01Z

/retest

aleskandro · 2025-02-06T10:36:20Z

controllers/operator/clusterpodplacementconfig_controller_test.go

+				By("Creating a v1beta1 ClusterPodPlacementConfig")
+				// err := k8sClient.Create(ctx, builder.NewClusterPodPlacementConfig().WithName(common.SingletonResourceObjectName).Build())
+				// Expect(err).NotTo(HaveOccurred(), "failed to create ClusterPodPlacementConfig", err)
+				// validateReconcile()
+				// Get the details
+				ppc := &v1beta1.ClusterPodPlacementConfig{}
+				err := k8sClient.Get(ctx, crclient.ObjectKeyFromObject(&v1beta1.ClusterPodPlacementConfig{
+					ObjectMeta: metav1.ObjectMeta{
+						Name:      common.SingletonResourceObjectName,
+						Namespace: utils.Namespace(),
+					},
+					Spec: v1beta1.ClusterPodPlacementConfigSpec{
+						LogVerbosity: "Normal",
+						Plugins: plugins.Plugins{
+							NodeAffinityScoring: &plugins.NodeAffinityScoring{
+								BasePlugin: plugins.BasePlugin{
+									Enabled: true,
+								},
+								Platforms: []plugins.NodeAffinityScoringPlatformTerm{
+									{Architecture: utils.ArchitectureArm64, Weight: 50},
+								},
+							},
+						},
+					},
+				}), ppc)
+				Expect(err).NotTo(HaveOccurred())
+				Eventually(func(g Gomega) {
+					// Verify the LogVerbosity field
+					g.Expect(ppc.Spec.LogVerbosity).NotTo(Equal("Normal"))
+					// Verify the Plugins field
+					g.Expect(ppc.Spec.Plugins.NodeAffinityScoring).To(BeNil())
+				}).Should(Succeed())
+			})
+			It("does not query the remote registry until the cache expires", func() {


Suggested change

By("Creating a v1beta1 ClusterPodPlacementConfig")

// err := k8sClient.Create(ctx, builder.NewClusterPodPlacementConfig().WithName(common.SingletonResourceObjectName).Build())

// Expect(err).NotTo(HaveOccurred(), "failed to create ClusterPodPlacementConfig", err)

// validateReconcile()

// Get the details

ppc := &v1beta1.ClusterPodPlacementConfig{}

err := k8sClient.Get(ctx, crclient.ObjectKeyFromObject(&v1beta1.ClusterPodPlacementConfig{

ObjectMeta: metav1.ObjectMeta{

Name: common.SingletonResourceObjectName,

Namespace: utils.Namespace(),

},

Spec: v1beta1.ClusterPodPlacementConfigSpec{

LogVerbosity: "Normal",

Plugins: plugins.Plugins{

NodeAffinityScoring: &plugins.NodeAffinityScoring{

BasePlugin: plugins.BasePlugin{

Enabled: true,

},

Platforms: []plugins.NodeAffinityScoringPlatformTerm{

{Architecture: utils.ArchitectureArm64, Weight: 50},

},

},

},

},

}), ppc)

Expect(err).NotTo(HaveOccurred())

Eventually(func(g Gomega) {

// Verify the LogVerbosity field

g.Expect(ppc.Spec.LogVerbosity).NotTo(Equal("Normal"))

// Verify the Plugins field

g.Expect(ppc.Spec.Plugins.NodeAffinityScoring).To(BeNil())

}).Should(Succeed())

})

It("does not query the remote registry until the cache expires", func() {

aleskandro · 2025-02-06T10:39:43Z

controllers/operator/clusterpodplacementconfig_controller_test.go

+				}).Should(Succeed())
+			})
+			It("does not query the remote registry until the cache expires", func() {
+				cppc := &v1beta1.ClusterPodPlacementConfig{ObjectMeta: metav1.ObjectMeta{


We should use the builder here.

Suggested change

cppc := &v1beta1.ClusterPodPlacementConfig{ObjectMeta: metav1.ObjectMeta{

err := k8sClient.Create(ctx, builder.NewClusterPodPlacementConfig().WithName(common.SingletonResourceObjectName).WithNodeAffinityScoring(true).WithNodeAffinityScoringTerm(utils.ArchitectureArm64, 50).Build())

Expect(err).NotTo(HaveOccurred(), "failed to create ClusterPodPlacementConfig", err)

validateReconcile()

Where WithNodeAffinityScoringPlugin and WithNodeAffinityScoringTerm are two methods to be implemented in https://github.com/openshift/multiarch-tuning-operator/blob/main/pkg/testing/builder/clusterpodplacementconfig.go.

The first only gets the value for the enabled field, the second gets (string, int) to append an element in the Platforms slice of the Plugins.NodeAffinityScoring spec of the CPPC.

aleskandro · 2025-02-06T10:42:08Z

controllers/operator/clusterpodplacementconfig_controller_test.go

+				}, v1alpha1obj)
+				Eventually(func(g Gomega) {
+					// Verify the LogVerbosity field
+					g.Expect(v1alpha1obj.Spec.LogVerbosity).NotTo(Equal("Normal"))
+
+					// Then, fetch it to ensure it exists and check the fields
+					ppc := &v1beta1.ClusterPodPlacementConfig{}
+					err = k8sClient.Get(ctx, crclient.ObjectKeyFromObject(cppc), ppc)
+					Expect(err).NotTo(HaveOccurred())
+
+					// Verify the LogVerbosity field
+					g.Expect(ppc.Spec.LogVerbosity).To(Equal("Normal"))
+					// Verify the Plugins field
+					g.Expect(ppc.Spec.Plugins.NodeAffinityScoring).NotTo(BeNil())
+					// verify the enabled bool
+					g.Expect(ppc.Spec.Plugins.NodeAffinityScoring.Enabled).To(BeTrue())
+					// verify platform
+					g.Expect(ppc.Spec.Plugins.NodeAffinityScoring.Platforms).To(ConsistOf(
+						plugins.NodeAffinityScoringPlatformTerm{Architecture: "ppc64le", Weight: 50},
+					))
+				}).Should(Succeed())
+			})


Suggested change

}, v1alpha1obj)

Eventually(func(g Gomega) {

// Verify the LogVerbosity field

g.Expect(v1alpha1obj.Spec.LogVerbosity).NotTo(Equal("Normal"))

// Then, fetch it to ensure it exists and check the fields

ppc := &v1beta1.ClusterPodPlacementConfig{}

err = k8sClient.Get(ctx, crclient.ObjectKeyFromObject(cppc), ppc)

Expect(err).NotTo(HaveOccurred())

// Verify the LogVerbosity field

g.Expect(ppc.Spec.LogVerbosity).To(Equal("Normal"))

// Verify the Plugins field

g.Expect(ppc.Spec.Plugins.NodeAffinityScoring).NotTo(BeNil())

// verify the enabled bool

g.Expect(ppc.Spec.Plugins.NodeAffinityScoring.Enabled).To(BeTrue())

// verify platform

g.Expect(ppc.Spec.Plugins.NodeAffinityScoring.Platforms).To(ConsistOf(

plugins.NodeAffinityScoringPlatformTerm{Architecture: "ppc64le", Weight: 50},

))

}).Should(Succeed())

})

}, v1alpha1obj)

Expect(err).NotTo(HaveOccurred())

No need for the Eventually block here.

pkenchap · 2025-02-06T14:14:20Z

/test unit

aleskandro · 2025-02-06T13:03:48Z

pkg/testing/builder/clusterpodplacementconfig.go

+}
+
+func (p *ClusterPodPlacementConfigBuilder) WithNodeAffinityScoringTerm(architecture string, weight int32) *ClusterPodPlacementConfigBuilder {
+	p.Spec.Plugins.NodeAffinityScoring.Platforms = []plugins.NodeAffinityScoringPlatformTerm{


We should append to an existing Platforms list or create if it's still nil

yes , even test was failing as it was not initialised . will check for nil.

aleskandro · 2025-02-06T13:04:22Z

pkg/testing/builder/clusterpodplacementconfig.go

@@ -34,3 +35,14 @@ func (p *ClusterPodPlacementConfigBuilder) WithLogVerbosity(logVerbosity common.
 func (p *ClusterPodPlacementConfigBuilder) Build() *v1beta1.ClusterPodPlacementConfig {
 	return p.ClusterPodPlacementConfig
 }
+
+func (p *ClusterPodPlacementConfigBuilder) WithNodeAffinityScoring(enabled bool) *ClusterPodPlacementConfigBuilder {
+	p.Spec.Plugins.NodeAffinityScoring.Enabled = enabled


You'd check if Plugins and NodeAffinityScoring are initialized first

yes sure , updated .

pkenchap · 2025-02-07T06:55:30Z

/retest-required

aleskandro · 2025-02-07T11:39:19Z

controllers/operator/clusterpodplacementconfig_controller_test.go

+			It("Should be possible to get the CPPC as a v1alpha1 with specs invalid weight regarding the plugins", func() {
+				By("Creating a v1beta1 ClusterPodPlacementConfig invalid weight")
+				err := k8sClient.Create(ctx, builder.NewClusterPodPlacementConfig().WithName(common.SingletonResourceObjectName).WithNodeAffinityScoring(true).WithNodeAffinityScoringTerm(utils.ArchitectureArm64, 200).Build())
+				Expect(err).NotTo(HaveOccurred(), "failed to create v1beta1 ClusterPodPlacementConfig invalid weight", err)
+				validateReconcile()
+				// Get the details
+				ppc := &v1beta1.ClusterPodPlacementConfig{}
+				err = k8sClient.Get(ctx, crclient.ObjectKeyFromObject(&v1beta1.ClusterPodPlacementConfig{
+					ObjectMeta: metav1.ObjectMeta{
+						Name:      common.SingletonResourceObjectName,
+						Namespace: utils.Namespace(),
+					},
+				}), ppc)
+				Expect(err).NotTo(HaveOccurred(), "failed to get v1beta1 ClusterPodPlacementConfig invalid weight", err)
+				// Get v1alpha1 ClusterPodPlacementConfig
+				By("Get a v1alpha1 ClusterPodPlacementConfig")
+				v1alpha1obj := &v1alpha1.ClusterPodPlacementConfig{}
+				err = k8sClient.Get(ctx, crclient.ObjectKey{
+					Name: common.SingletonResourceObjectName,
+				}, v1alpha1obj)
+				Expect(err).NotTo(HaveOccurred(), "failed to get v1alpha1 ClusterPodPlacementConfig invalid weight", err)
+			})


Suggested change

It("Should be possible to get the CPPC as a v1alpha1 with specs invalid weight regarding the plugins", func() {

By("Creating a v1beta1 ClusterPodPlacementConfig invalid weight")

err := k8sClient.Create(ctx, builder.NewClusterPodPlacementConfig().WithName(common.SingletonResourceObjectName).WithNodeAffinityScoring(true).WithNodeAffinityScoringTerm(utils.ArchitectureArm64, 200).Build())

Expect(err).NotTo(HaveOccurred(), "failed to create v1beta1 ClusterPodPlacementConfig invalid weight", err)

validateReconcile()

// Get the details

ppc := &v1beta1.ClusterPodPlacementConfig{}

err = k8sClient.Get(ctx, crclient.ObjectKeyFromObject(&v1beta1.ClusterPodPlacementConfig{

ObjectMeta: metav1.ObjectMeta{

Name: common.SingletonResourceObjectName,

Namespace: utils.Namespace(),

},

}), ppc)

Expect(err).NotTo(HaveOccurred(), "failed to get v1beta1 ClusterPodPlacementConfig invalid weight", err)

// Get v1alpha1 ClusterPodPlacementConfig

By("Get a v1alpha1 ClusterPodPlacementConfig")

v1alpha1obj := &v1alpha1.ClusterPodPlacementConfig{}

err = k8sClient.Get(ctx, crclient.ObjectKey{

Name: common.SingletonResourceObjectName,

}, v1alpha1obj)

Expect(err).NotTo(HaveOccurred(), "failed to get v1alpha1 ClusterPodPlacementConfig invalid weight", err)

})

It("Should not allow invalid weigths", func() {

By("Creating a v1beta1 ClusterPodPlacementConfig invalid weight")

err := k8sClient.Create(ctx, builder.NewClusterPodPlacementConfig().WithName(common.SingletonResourceObjectName).WithNodeAffinityScoring(true).WithNodeAffinityScoringTerm(utils.ArchitectureArm64, 200).Build())

Expect(err).To(HaveOccurred(), "no ClusterPodPlacementConfig with invalid weights in the plugins.NodeAffinityScoring.Platforms[].Weight should be accepted", err)

})

aleskandro · 2025-02-07T11:39:35Z

controllers/operator/clusterpodplacementconfig_controller_test.go

+			It("Should be possible to get the CPPC as a v1alpha1 with specs only enabled regarding the plugins", func() {
+				By("Creating a v1beta1 ClusterPodPlacementConfig invalid weight")
+				err := k8sClient.Create(ctx, builder.NewClusterPodPlacementConfig().WithName(common.SingletonResourceObjectName).WithNodeAffinityScoring(true).Build())
+				Expect(err).NotTo(HaveOccurred(), "failed to create v1beta1 ClusterPodPlacementConfig enabled", err)
+				validateReconcile()
+				// Get the details
+				ppc := &v1beta1.ClusterPodPlacementConfig{}
+				err = k8sClient.Get(ctx, crclient.ObjectKeyFromObject(&v1beta1.ClusterPodPlacementConfig{
+					ObjectMeta: metav1.ObjectMeta{
+						Name:      common.SingletonResourceObjectName,
+						Namespace: utils.Namespace(),
+					},
+				}), ppc)
+				Expect(err).NotTo(HaveOccurred(), "failed to get v1beta1 ClusterPodPlacementConfig enabled", err)
+				// Get v1alpha1 ClusterPodPlacementConfig
+				By("Get a v1alpha1 ClusterPodPlacementConfig")
+				v1alpha1obj := &v1alpha1.ClusterPodPlacementConfig{}
+				err = k8sClient.Get(ctx, crclient.ObjectKey{
+					Name: common.SingletonResourceObjectName,
+				}, v1alpha1obj)
+				Expect(err).NotTo(HaveOccurred(), "failed to get v1alpha1 ClusterPodPlacementConfig enabled", err)
+			})
+			It("Should be possible to get the CPPC as a v1alpha1 with specs enabled false regarding the plugins", func() {
+				By("Creating a v1beta1 ClusterPodPlacementConfig invalid weight")
+				err := k8sClient.Create(ctx, builder.NewClusterPodPlacementConfig().WithName(common.SingletonResourceObjectName).WithNodeAffinityScoring(false).Build())
+				Expect(err).NotTo(HaveOccurred(), "failed to create v1beta1 ClusterPodPlacementConfig enabled false", err)
+				validateReconcile()
+				// Get the details
+				ppc := &v1beta1.ClusterPodPlacementConfig{}
+				err = k8sClient.Get(ctx, crclient.ObjectKeyFromObject(&v1beta1.ClusterPodPlacementConfig{
+					ObjectMeta: metav1.ObjectMeta{
+						Name:      common.SingletonResourceObjectName,
+						Namespace: utils.Namespace(),
+					},
+				}), ppc)
+				Expect(err).NotTo(HaveOccurred(), "failed to get v1beta1 ClusterPodPlacementConfig enabled false", err)
+				// Get v1alpha1 ClusterPodPlacementConfig
+				By("Get a v1alpha1 ClusterPodPlacementConfig")
+				v1alpha1obj := &v1alpha1.ClusterPodPlacementConfig{}
+				err = k8sClient.Get(ctx, crclient.ObjectKey{
+					Name: common.SingletonResourceObjectName,
+				}, v1alpha1obj)
+				Expect(err).NotTo(HaveOccurred(), "failed to get v1alpha1 ClusterPodPlacementConfig enabled false", err)
+			})


Suggested change

It("Should be possible to get the CPPC as a v1alpha1 with specs only enabled regarding the plugins", func() {

By("Creating a v1beta1 ClusterPodPlacementConfig invalid weight")

err := k8sClient.Create(ctx, builder.NewClusterPodPlacementConfig().WithName(common.SingletonResourceObjectName).WithNodeAffinityScoring(true).Build())

Expect(err).NotTo(HaveOccurred(), "failed to create v1beta1 ClusterPodPlacementConfig enabled", err)

validateReconcile()

// Get the details

ppc := &v1beta1.ClusterPodPlacementConfig{}

err = k8sClient.Get(ctx, crclient.ObjectKeyFromObject(&v1beta1.ClusterPodPlacementConfig{

ObjectMeta: metav1.ObjectMeta{

Name: common.SingletonResourceObjectName,

Namespace: utils.Namespace(),

},

}), ppc)

Expect(err).NotTo(HaveOccurred(), "failed to get v1beta1 ClusterPodPlacementConfig enabled", err)

// Get v1alpha1 ClusterPodPlacementConfig

By("Get a v1alpha1 ClusterPodPlacementConfig")

v1alpha1obj := &v1alpha1.ClusterPodPlacementConfig{}

err = k8sClient.Get(ctx, crclient.ObjectKey{

Name: common.SingletonResourceObjectName,

}, v1alpha1obj)

Expect(err).NotTo(HaveOccurred(), "failed to get v1alpha1 ClusterPodPlacementConfig enabled", err)

})

It("Should be possible to get the CPPC as a v1alpha1 with specs enabled false regarding the plugins", func() {

By("Creating a v1beta1 ClusterPodPlacementConfig invalid weight")

err := k8sClient.Create(ctx, builder.NewClusterPodPlacementConfig().WithName(common.SingletonResourceObjectName).WithNodeAffinityScoring(false).Build())

Expect(err).NotTo(HaveOccurred(), "failed to create v1beta1 ClusterPodPlacementConfig enabled false", err)

validateReconcile()

// Get the details

ppc := &v1beta1.ClusterPodPlacementConfig{}

err = k8sClient.Get(ctx, crclient.ObjectKeyFromObject(&v1beta1.ClusterPodPlacementConfig{

ObjectMeta: metav1.ObjectMeta{

Name: common.SingletonResourceObjectName,

Namespace: utils.Namespace(),

},

}), ppc)

Expect(err).NotTo(HaveOccurred(), "failed to get v1beta1 ClusterPodPlacementConfig enabled false", err)

// Get v1alpha1 ClusterPodPlacementConfig

By("Get a v1alpha1 ClusterPodPlacementConfig")

v1alpha1obj := &v1alpha1.ClusterPodPlacementConfig{}

err = k8sClient.Get(ctx, crclient.ObjectKey{

Name: common.SingletonResourceObjectName,

}, v1alpha1obj)

Expect(err).NotTo(HaveOccurred(), "failed to get v1alpha1 ClusterPodPlacementConfig enabled false", err)

})

…terPodPlacementConfig Signed-off-by: Punith Kenchappa <[email protected]>

openshift-ci · 2025-02-10T06:49:03Z

@pkenchap: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/unit	`42fcd8d`	link	true	`/test unit`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 20, 2024

openshift-ci bot assigned pkenchap Nov 20, 2024

openshift-ci bot requested review from aleskandro and AnnaZivkovic November 20, 2024 05:13

aleskandro reviewed Nov 20, 2024

View reviewed changes

apis/multiarch/common/plugins/plugins.go Outdated Show resolved Hide resolved

aleskandro reviewed Nov 20, 2024

View reviewed changes

apis/multiarch/common/plugins/plugins.go Outdated Show resolved Hide resolved

aleskandro reviewed Nov 20, 2024

View reviewed changes

apis/multiarch/v1beta1/clusterpodplacementconfig_types.go Outdated Show resolved Hide resolved

aleskandro reviewed Nov 20, 2024

View reviewed changes

apis/multiarch/common/plugins/plugins.go Outdated Show resolved Hide resolved

pkenchap force-pushed the MULTIARCH-5058 branch 2 times, most recently from 2337fb3 to 7994305 Compare November 21, 2024 08:55

aleskandro reviewed Nov 21, 2024

View reviewed changes

apis/multiarch/common/plugins/nodeaffinityscoring_plugin.go Outdated Show resolved Hide resolved

aleskandro reviewed Nov 21, 2024

View reviewed changes

apis/multiarch/common/plugins/nodeaffinityscoring_plugin.go Outdated Show resolved Hide resolved

aleskandro reviewed Nov 21, 2024

View reviewed changes

apis/multiarch/common/plugins/nodeaffinityscoring_plugin.go Outdated Show resolved Hide resolved

aleskandro reviewed Nov 21, 2024

View reviewed changes

apis/multiarch/common/plugins/nodeaffinityscoring_plugin.go Outdated Show resolved Hide resolved

aleskandro reviewed Nov 21, 2024

View reviewed changes

apis/multiarch/common/plugins/nodeaffinityscoring_plugin.go Outdated Show resolved Hide resolved

pkenchap force-pushed the MULTIARCH-5058 branch from 7994305 to e5e67dd Compare November 26, 2024 06:44