RFE-7406: Include the K8s ingress resource in namespace inspect collection

[oarribas]

Including the K8s ingress.networking.k8s.io resource in namespace inspect collections could help to identify if the K8s ingress is in use.
It shouldn't increase the size of the inspect or must-gather a lot, as the resource shouldn't be too big.

[openshift-ci-robot]

@oarribas: This pull request references RFE-7406 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the feature request to target the "4.19.0" version, but no target version was set.

In response to this:

Including the K8s ingress.networking.k8s.io resource in namespace inspect collections could help to identify the K8s ingress is in use.
It shouldn't increase the size of the inspect or must-gather a lot, as the resource shouldn't be too big.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: oarribas
Once this PR has been reviewed and has the lgtm label, please assign ingvagabund for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@oarribas: This pull request references RFE-7406 which is a valid jira issue.

In response to this:

Including the K8s ingress.networking.k8s.io resource in namespace inspect collections could help to identify if the K8s ingress is in use.
It shouldn't increase the size of the inspect or must-gather a lot, as the resource shouldn't be too big.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[oarribas]

/retest

[oarribas]

/retest

[ardaguclu]

I think, we can't merge anything without having concrete metrics about how the change will impact the logs size and duration -- Especially after trying to fix and lower the logs sizes due to some issues.

I'd prefer waiting for the acceptance of the RFE by the workloads team first.
/hold

[oarribas]

/retest

[palonsoro]

@ardaguclu bear in mind that this resource is used only in user application namespaces. This means that must-gather should not collect it and should hence not see a difference in size by default.

The difference in size would happen only when the customer runs the inspect on their own application namespaces (something we need quite often to provide good support). And in that case:

• Inspects of concrete namespaces are usually not that big.
• Users have higher control in the size of the inspects (e.g. inspect only one namespace instead of all the impacted ones, setting the pod log sizes...)
• Increase would be of very few KBs in most cases.

[oarribas]

/retest

[oarribas]

/retest

[oarribas]

/retest

[oarribas]

/retest

[oarribas]

it's not clear the test is really failing because the changes in this PR

/retest

[oarribas]

/retest

[oarribas]

/retest

[oarribas]

Checking the failing job [1], I cannot identify where the error with the check is. Not clear if caused by the changes in this PR, or any issue with the check.

/retest

[1] https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_oc/2004/pull-ci-openshift-oc-master-verify/1916749485623480320

[oarribas]

/retest

[oarribas]

/retest

[oarribas]

/retest

[oarribas]

Changed spaces to tabs

[oarribas]

/retest

[oarribas]

/retest-required

[oarribas]

/retest-required

[oarribas]

/retest-required

[oarribas]

/retest-required

[openshift-ci]

@oarribas: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.