Skip to content

WRKLDS-1716: oc serviceaccounts: Remove as deprecated #2034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tchap
Copy link
Contributor

@tchap tchap commented Jun 4, 2025

This range of commands has been deprecated for 2 years now.

This range of commands has been deprecated for 2 years now.
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 4, 2025

@tchap: This pull request references WRKLDS-1716 which is a valid jira issue.

In response to this:

This range of commands has been deprecated for 2 years now.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 4, 2025
@openshift-ci openshift-ci bot requested review from ardaguclu and ingvagabund June 4, 2025 13:39
Copy link
Contributor

openshift-ci bot commented Jun 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tchap
Once this PR has been reviewed and has the lgtm label, please assign ingvagabund for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tchap
Copy link
Contributor Author

tchap commented Jun 4, 2025

I am not entirely sure how serious is the usage in
https://github.com/search?q=org%3Aopenshift+%22oc+serviceaccounts%22&type=code

What do you think @ardaguclu ?

Copy link
Contributor

openshift-ci bot commented Jun 4, 2025

@tchap: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 24b17fc link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-certrotation 24b17fc link false /test e2e-aws-certrotation
ci/prow/e2e-aws-ovn 24b17fc link true /test e2e-aws-ovn
ci/prow/e2e-metal-ipi-ovn-ipv6 24b17fc link false /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tchap
Copy link
Contributor Author

tchap commented Jun 4, 2025

We need to align/remove the failing test.

@ardaguclu
Copy link
Member

We need to align/remove the failing test.

Based on this comment https://github.com/openshift/origin/blob/9508b94995c110e3a6c988dbf35a8920bc36c3ed/test/extended/cli/admin.go#L478-L487, test needs to be updated to use create token instead of create serviceaccount

@tchap
Copy link
Contributor Author

tchap commented Jun 19, 2025

/hold

I am postponing this, also need to really make sure it's unused.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants