-
Notifications
You must be signed in to change notification settings - Fork 407
WRKLDS-1716: oc serviceaccounts: Remove as deprecated #2034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This range of commands has been deprecated for 2 years now.
@tchap: This pull request references WRKLDS-1716 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tchap The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I am not entirely sure how serious is the usage in What do you think @ardaguclu ? |
@tchap: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
We need to align/remove the failing test. |
Based on this comment https://github.com/openshift/origin/blob/9508b94995c110e3a6c988dbf35a8920bc36c3ed/test/extended/cli/admin.go#L478-L487, test needs to be updated to use |
/hold I am postponing this, also need to really make sure it's unused. |
This range of commands has been deprecated for 2 years now.