WIP: WRKLDS-1713: Migrate to distribution/[email protected]

[tchap]

Blocked by openshift/library-go#1972

[openshift-ci-robot]

@tchap: This pull request references WRKLDS-1713 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Blocked by openshift/library-go#1972

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tchap
Once this PR has been reviewed and has the lgtm label, please assign atiratree for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@tchap: This pull request references WRKLDS-1713 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Blocked by openshift/library-go#1972

It may also be necessary to backport 568b70b

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@tchap: This pull request references WRKLDS-1713 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Blocked by openshift/library-go#1972

It may also be necessary to backport 568b70b , or it can be done when actually porting oc-mirror to the current oc.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@tchap: This pull request references WRKLDS-1713 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Blocked by openshift/library-go#1972

It may also be necessary to backport 568b70b , or it can be done when actually porting oc-mirror to the current oc.

Other than cosmetic changes, support for schema1 is dropped here since it's deprecated and no longer supported in distribution/v3.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ardaguclu]

There are many bits in this PR moving around (k8s bumps, library-go changes, deprecations). It is very hard to trace the code changes. Would it be better to drop schemav1 support in a separate clean PR?

[tchap]

There are many bits in this PR moving around (k8s bumps, library-go changes, deprecations). It is very hard to trace the code changes. Would it be better to drop schemav1 support in a separate clean PR?

@ardaguclu Yes, it's certainly possible to drop it is a separate PR. This actually just contains all changes necessary to migrate to distribution/[email protected], but it may make sense to drop this functionality separately so that it is actually possible to review. I will proceed with that.

[tchap]

Removing schema1 in #2037

[openshift-ci-robot]

@tchap: This pull request references WRKLDS-1713 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Blocked by openshift/library-go#1972

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[tchap]

Rebased onto main so schema1 changes are no longer a part of this PR.

[tchap]

/retest

[tchap]

The failing required test prints

go: go.mod requires go >= 1.23.7 (running go 1.23.6; GOTOOLCHAIN=local)

so I guess the issue with required Go version is not gone yet.

[tchap]

/retest-required

[tchap]

We have to wait for the build images to be updated or distribution/distribution#4637 (comment)

[tchap]

/retest-required

[openshift-ci]

@tchap: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	46dd19d	link	false	/test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.