Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.18 Release notes for multi-arch features #88745

Merged
merged 1 commit into from
Feb 20, 2025
Merged

4.18 Release notes for multi-arch features #88745

merged 1 commit into from
Feb 20, 2025

Conversation

sr1kar99
Copy link
Contributor

@sr1kar99 sr1kar99 commented Feb 18, 2025 •
edited
Loading

Version(s):
4.18

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 18, 2025
@sr1kar99 sr1kar99 force-pushed the release-notes-multiarch-4-18 branch from 5d58136 to 2f31bba Compare February 18, 2025 09:35
@sr1kar99
Copy link
Contributor Author

sr1kar99 commented Feb 18, 2025 •
edited
Loading

@jeffdyoung and @lwan-wanglin
Could you please review the release note for OSDOCS-12855?
Thanks!

@sr1kar99
Copy link
Contributor Author

@Prashanth684 and @wewang58
Could you please review the release note for MULTIARCH-4560?
Thanks!

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 18, 2025 •
edited
Loading

🤖 Thu Feb 20 08:38:38 - Prow CI generated the docs preview:

https://88745--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-18-release-notes.html

@wewang58
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Feb 18, 2025
@lwan-wanglin
Copy link

LGTM

@sr1kar99 sr1kar99 force-pushed the release-notes-multiarch-4-18 branch from 2f31bba to 5684510 Compare February 19, 2025 10:52
@sr1kar99
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 19, 2025
@eromanova97
Copy link
Contributor

/remove-label peer-review-needed

/label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 19, 2025
eromanova97
eromanova97 reviewed Feb 19, 2025
View reviewed changes
Copy link
Contributor

@eromanova97 eromanova97 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! I have just small suggestions, otherwise looks good to me!

Note: I noticed right before publishing the review, there is some new comment from SME that migh result in some additional changes. I am finishing this review to not block this, in case there are changes you will need peer-reviewed again, please raise the peer-review-needed label again or ping me. Thanks!

/remove-label peer-review-in-progress
/label peer-review-done

release_notes/ocp-4-18-release-notes.adoc Outdated Show resolved Hide resolved
release_notes/ocp-4-18-release-notes.adoc Outdated Show resolved Hide resolved
release_notes/ocp-4-18-release-notes.adoc Outdated Show resolved Hide resolved
release_notes/ocp-4-18-release-notes.adoc Outdated Show resolved Hide resolved
release_notes/ocp-4-18-release-notes.adoc Show resolved Hide resolved
@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Feb 19, 2025
@sr1kar99 sr1kar99 force-pushed the release-notes-multiarch-4-18 branch from 5684510 to 2f7ae59 Compare February 20, 2025 08:17
@sr1kar99
Copy link
Contributor Author

Hello! I have just small suggestions, otherwise looks good to me!

Note: I noticed right before publishing the review, there is some new comment from SME that migh result in some additional changes. I am finishing this review to not block this, please raise the peer-review-needed label again or ping me in case there are changes you will need peer-reviewed again. Thanks!

/remove-label peer-review-in-progress /label peer-review-done

Thanks for the review! :)
No new changes are required as as confirmed by the SME in his response to Jeff's query.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 20, 2025

@sr1kar99: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sr1kar99
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Feb 20, 2025
@bergerhoffer
Copy link
Contributor

/label merge-review-in-progress

@openshift-ci openshift-ci bot added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Feb 20, 2025
@bergerhoffer bergerhoffer added this to the Planned for 4.18 GA milestone Feb 20, 2025
bergerhoffer
bergerhoffer reviewed Feb 20, 2025
View reviewed changes
Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing about this adding a duplicate section for postinstall (and out of order).

I know that it's past your working hours though, and with freeze being today, let me check with @kalexand-rh on whether we should just merge this an then fix the location in a separate PR.

release_notes/ocp-4-18-release-notes.adoc
@@ -593,6 +593,26 @@ With this release, the Agent-based Installer supports creating assets that can b

For more information, see xref:../installing/installing_with_agent_based_installer/installing-using-iscsi.adoc#installing-using-iscsi[Preparing installation assets for iSCSI booting].

[id="ocp-4.18-postinstallation-configuration_{context}"]
=== Postinstallation configuration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sr1kar99 This is adding a new postinstall section (out of alphabetical order), and there is already a postinstall section below. You should move your stuff down below

@bergerhoffer
Copy link
Contributor

Chatted with Kathryn and yes I'll go ahead and merge this, and the follow up with a PR to move it to the correct section below!

@bergerhoffer bergerhoffer merged commit 566c2b6 into openshift:enterprise-4.18 Feb 20, 2025
2 checks passed
@bergerhoffer bergerhoffer mentioned this pull request Feb 20, 2025
Open
@bergerhoffer
Copy link
Contributor

Follow-up PR is here: #88998

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Prashanth684 Prashanth684 Prashanth684 left review comments

@bergerhoffer bergerhoffer bergerhoffer left review comments

@jeffdyoung jeffdyoung jeffdyoung left review comments

@eromanova97 eromanova97 eromanova97 left review comments

Assignees
No one assigned
Labels
branch/enterprise-4.18 merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
Planned for 4.18 GA
Development

Successfully merging this pull request may close these issues.
8 participants
@sr1kar99 @ocpdocs-previewbot @wewang58 @lwan-wanglin @eromanova97 @bergerhoffer @Prashanth684 @jeffdyoung