[release-4.15] OCPBUGS-55477: support provider type external #29739
Conversation
Support platform type `External` as a valid provider in the test framework. The external platform initially act as None, and not require additional configuration at this moment. This change will add the minimum support to allow CI readiness for this platform. The initial support has been added to 4.19, in order to skip permanent failures added in upstream kube on 4.18. As the --provider flag is added in the CI step level, and that step does not support release check, it will be complex to implement a logic in CI instead of just global support of --provider across all versions the platform type external jobs are tested: 4.15+.
openshift-ci-robot
added
jira/valid-reference
|
@mtulio: This pull request references Jira Issue OCPBUGS-55477, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test ? |
|
@mtulio: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
This PR is ready for review. PTAL? /assign @rvanderp3 @jupierce |
|
@mtulio: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-staff-engineers] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
jupierce
added
the
backport-risk-assessed
openshift-ci
bot
assigned adambkaplan, dgoodwin, gangwgr, jadhaj, kasturinarra, Moebasim, pamoedom and prabhapa
jupierce
added
the
cherry-pick-approved
|
/test e2e-gcp-ovn-upgrade |
|
/jira refresh |
|
@mtulio: This pull request references Jira Issue OCPBUGS-55477, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@mtulio: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-ci-robot
added
the
jira/valid-bug
|
@mtulio: This pull request references Jira Issue OCPBUGS-55477, which is valid. 7 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
removed
the
jira/invalid-bug
|
/lgtm |
|
Slack update: @deads2k is going to update the OWNERs file of <=4.15 to reflect as latest versions. |
Test skips from workflow and jobs must be removed as all known issues have been resolved*, and permanent failures was skipped in the test framework for platform type external (provider type). See the consolidated Jira task for more information about all changes: https://issues.redhat.com/browse/SPLAT-2090 *except 4.15, non-blocking, which is blocked in review phase: openshift/origin#29739
Test skips from workflow and jobs must be removed as all known issues have been resolved*, and permanent failures was skipped in the test framework for platform type external (provider type). See the consolidated Jira task for more information about all changes: https://issues.redhat.com/browse/SPLAT-2090 *except 4.15, non-blocking, which is blocked in review phase: openshift/origin#29739
Test skips from workflow and jobs must be removed as all known issues have been resolved*, and permanent failures was skipped in the test framework for platform type external (provider type). See the consolidated Jira task for more information about all changes: https://issues.redhat.com/browse/SPLAT-2090 *except 4.15, non-blocking, which is blocked in review phase: openshift/origin#29739
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcpowermac, mtulio, neisw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@mtulio: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 754fbc4
into
openshift:release-4.15
|
@mtulio: Jira Issue OCPBUGS-55477: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-55477 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-tests |
Support platform type
Externalas a valid provider in the test framework. The external platform initially act as None, and not require additional configuration at this moment. This change will add the minimum support to allow CI readiness for this platform.The initial support has been added to 4.19, in order to skip permanent failures added in upstream kube on 4.18.
As the --provider flag is added in the CI step level, and that step does not support release check, it will be complex to implement a logic in CI instead of just global support of --provider across all versions the platform type external jobs are tested: 4.15+.
References: