Skip to content

OCPBUGS-56696: fix: remove un-needed test #29849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release-4.16
Choose a base branch
from

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #28979

/assign liqcui

This test does not accuratly capture the bug it references, the matcher would match on correct reasons to mark a mc as degraded thus giving false positives. Also the test is not needed because if the condition the test is checking for were ever to arise the install would simply fail before we ever come to this state. The bug the test references also has tests so we should be fine to remove this check since it's not providing any value.

Signed-off-by: ehila <[email protected]>
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 27, 2025

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: OCPEDGE-1182

In response to this:

This is an automated cherry-pick of #28979

/assign liqcui

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jmencak
Copy link
Contributor

jmencak commented May 27, 2025

/lgtm
@liqcui , we'll probaby need to retitle to refer to https://issues.redhat.com/browse/OCPBUGS-56696 . We'll also need to get valid labels in place.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2025
@liqcui
Copy link
Contributor

liqcui commented May 27, 2025

/retitle OCPBUGS-56696: fix: remove un-needed test

@openshift-ci openshift-ci bot changed the title [release-4.16] OCPEDGE-1182: fix: remove un-needed test OCPBUGS-56696: fix: remove un-needed test May 27, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 27, 2025
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-56696, which is invalid:

  • expected the bug to target the "4.16.z" version, but no target version was set
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-56696 to depend on a bug targeting a version in 4.17.0, 4.17.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #28979

/assign liqcui

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jmencak
Copy link
Contributor

jmencak commented May 27, 2025

/jira refresh

@openshift-ci-robot
Copy link

@jmencak: This pull request references Jira Issue OCPBUGS-56696, which is invalid:

  • expected Jira Issue OCPBUGS-56696 to depend on a bug targeting a version in 4.17.0, 4.17.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jmencak
Copy link
Contributor

jmencak commented May 27, 2025

@sebsoto , apart from /approve, would you be able to provide /label jira/valid-bug ? It would be great to avoid the pain of manually backporting and VERIFYing this from 4.19 down to 4.17. Many thanks!

@liqcui
Copy link
Contributor

liqcui commented May 27, 2025

/retest

@sebsoto
Copy link

sebsoto commented May 27, 2025

Will defer to @romfreiman or @rphillips as this seems to be in their wheelhouse.

@liqcui
Copy link
Contributor

liqcui commented May 28, 2025

/retest

1 similar comment
@liqcui
Copy link
Contributor

liqcui commented May 28, 2025

/retest

Copy link
Contributor

openshift-ci bot commented May 28, 2025

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-upgrade 6746920 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-metal-ipi-ovn-dualstack-local-gateway 6746920 link false /test e2e-metal-ipi-ovn-dualstack-local-gateway
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 6746920 link false /test e2e-vsphere-ovn-dualstack-primaryv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jmencak
Copy link
Contributor

jmencak commented May 28, 2025

The 3 failing tests are not NTO related and the failing tests do not seem to be required. @sebsoto, any chance of an approval? Thank you.

Copy link
Contributor

openshift-ci bot commented May 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jmencak, openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign sebsoto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmencak
Copy link
Contributor

jmencak commented May 28, 2025

/assign @sebsoto

@sebsoto
Copy link

sebsoto commented May 28, 2025

@jmencak see #29849 (comment)

@jmencak
Copy link
Contributor

jmencak commented May 28, 2025

@jmencak see #29849 (comment)

I've seen it, Sebastian, thank you. I'm not asking for jira/valid-bug from you. I'm only asking for /approve as the bot suggested. If you're unable to provide /approve, that's also fine, even though I'm not sure why the bot suggested it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants