Skip to content

OCPBUGS-55830: Only update boot disks during GCP boot image updates tests #29869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2025
Merged

OCPBUGS-55830: Only update boot disks during GCP boot image updates tests #29869

merged 1 commit into from
May 31, 2025

Conversation

djoshy
Copy link
Contributor

@djoshy djoshy commented May 28, 2025

Updates test to account for openshift/machine-config-operator#5084

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels May 28, 2025
@openshift-ci-robot
Copy link

@djoshy: This pull request references Jira Issue OCPBUGS-55830, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @miyadav

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Updates test to account for openshift/machine-config-operator#5084

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2025
@openshift-ci-robot openshift-ci-robot mentioned this pull request May 29, 2025
Merged
@djoshy
Copy link
Contributor Author

djoshy commented May 29, 2025

/retest-required

yuqi-zhang
yuqi-zhang approved these changes May 29, 2025
View reviewed changes
Copy link
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 88edc2f and 2 for PR HEAD fe4f715 in total

@openshift-trt openshift-trt
Copy link

openshift-trt bot commented May 30, 2025

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New Test Risks for sha: fe4f715

Job Name New Test Risk
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift High - "[sig-network] Netpol NetworkPolicy between server and client should allow egress access on one named port [Feature:NetworkPolicy] [Suite:openshift/conformance/parallel] [Suite:k8s]" is a new test that was not present in all runs against the current commit, and also failed 1 time(s).
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift High - "[sig-network] Netpol NetworkPolicy between server and client should allow ingress access from namespace on one named port [Feature:NetworkPolicy] [Suite:openshift/conformance/parallel] [Suite:k8s]" is a new test that was not present in all runs against the current commit, and also failed 1 time(s).
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift High - "[sig-network] Netpol NetworkPolicy between server and client should allow ingress access on one named port [Feature:NetworkPolicy] [Suite:openshift/conformance/parallel] [Suite:k8s]" is a new test that was not present in all runs against the current commit, and also failed 1 time(s).

New tests seen in this PR at sha: fe4f715

  • "[sig-network] Netpol NetworkPolicy between server and client should allow egress access on one named port [Feature:NetworkPolicy] [Suite:openshift/conformance/parallel] [Suite:k8s]" [Total: 2, Pass: 1, Fail: 1, Flake: 0]
  • "[sig-network] Netpol NetworkPolicy between server and client should allow ingress access from namespace on one named port [Feature:NetworkPolicy] [Suite:openshift/conformance/parallel] [Suite:k8s]" [Total: 2, Pass: 1, Fail: 1, Flake: 0]
  • "[sig-network] Netpol NetworkPolicy between server and client should allow ingress access on one named port [Feature:NetworkPolicy] [Suite:openshift/conformance/parallel] [Suite:k8s]" [Total: 2, Pass: 1, Fail: 1, Flake: 0]

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 88edc2f and 2 for PR HEAD fe4f715 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 30, 2025 •
edited
Loading

@djoshy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-serial-publicnet-1of2 fe4f715 link false /test e2e-aws-ovn-serial-publicnet-1of2
ci/prow/e2e-aws-disruptive fe4f715 link false /test e2e-aws-disruptive
ci/prow/e2e-gcp-csi fe4f715 link false /test e2e-gcp-csi
ci/prow/e2e-azure-ovn-upgrade fe4f715 link false /test e2e-azure-ovn-upgrade
ci/prow/e2e-openstack-ovn fe4f715 link false /test e2e-openstack-ovn
ci/prow/e2e-openstack-serial fe4f715 link false /test e2e-openstack-serial
ci/prow/e2e-aws-ovn-single-node-upgrade fe4f715 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-vsphere-ovn-etcd-scaling fe4f715 link false /test e2e-vsphere-ovn-etcd-scaling
ci/prow/e2e-gcp-fips-serial-2of2 fe4f715 link false /test e2e-gcp-fips-serial-2of2
ci/prow/okd-e2e-gcp fe4f715 link false /test okd-e2e-gcp
ci/prow/e2e-gcp-fips-serial-1of2 fe4f715 link false /test e2e-gcp-fips-serial-1of2
ci/prow/e2e-aws-ovn-kube-apiserver-rollout fe4f715 link false /test e2e-aws-ovn-kube-apiserver-rollout
ci/prow/4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback fe4f715 link false /test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback
ci/prow/e2e-gcp-disruptive fe4f715 link false /test e2e-gcp-disruptive
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 fe4f715 link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/e2e-aws-ovn-etcd-scaling fe4f715 link false /test e2e-aws-ovn-etcd-scaling
ci/prow/e2e-gcp-ovn-etcd-scaling fe4f715 link false /test e2e-gcp-ovn-etcd-scaling
ci/prow/e2e-aws-ovn-single-node fe4f715 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-azure fe4f715 link false /test e2e-azure
ci/prow/e2e-azure-ovn-etcd-scaling fe4f715 link false /test e2e-azure-ovn-etcd-scaling

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e47a79b and 1 for PR HEAD fe4f715 in total

@openshift-merge-bot openshift-merge-bot bot merged commit 202a238 into openshift:main May 31, 2025
39 of 59 checks passed
@openshift-ci-robot
Copy link

@djoshy: Jira Issue OCPBUGS-55830 is in an unrecognized state (Verified) and will not be moved to the MODIFIED state.

In response to this:

Updates test to account for openshift/machine-config-operator#5084

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@djoshy
Copy link
Contributor Author

djoshy commented Jun 2, 2025

/cherry-pick release-4.19 release-4.18

@openshift-cherrypick-robot
Copy link

@djoshy: new pull request created: #29878

In response to this:

/cherry-pick release-4.19 release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 2, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuqi-zhang yuqi-zhang yuqi-zhang approved these changes

@miyadav miyadav Awaiting requested review from miyadav

@isabella-janssen isabella-janssen Awaiting requested review from isabella-janssen

@RishabhSaini RishabhSaini Awaiting requested review from RishabhSaini

Assignees

@yuqi-zhang yuqi-zhang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@djoshy @openshift-ci-robot @openshift-cherrypick-robot @yuqi-zhang