Skip to content

MCO-1722: Handle check for Disconnnected Clusters for PIS Testing using curl #29870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2025
Merged

MCO-1722: Handle check for Disconnnected Clusters for PIS Testing using curl #29870

merged 1 commit into from
May 31, 2025

Conversation

RishabhSaini
Copy link
Contributor

@RishabhSaini RishabhSaini commented May 29, 2025 •
edited
Loading

helpers: Handle Disconnnected Clusters using curl
pinnedimages: In metal disconnected case, check for existence of images prior to MCN status

@openshift-ci openshift-ci bot requested review from djoshy and pablintino May 29, 2025 15:51
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2025
@RishabhSaini RishabhSaini changed the title Handle check for Disconnnected Clusters for PIS Testing using curl MCO-1722: Handle check for Disconnnected Clusters for PIS Testing using curl May 29, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 29, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 29, 2025 •
edited by openshift-ci bot
Loading

@RishabhSaini: This pull request references MCO-1722 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

pablintino
pablintino reviewed May 29, 2025
View reviewed changes
Copy link
Contributor

@pablintino pablintino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no PR description and the commit message seems to cover only the change to test/extended/machine_config/helpers.go but not the change to test/extended/machine_config/pinnedimages.go

@openshift-trt openshift-trt
Copy link

openshift-trt bot commented May 29, 2025

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New Test Risks for sha: a867ae1

Job Name New Test Risk
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift High - "[sig-network] Netpol NetworkPolicy between server and client should allow egress access on one named port [Feature:NetworkPolicy] [Suite:openshift/conformance/parallel] [Suite:k8s]" is a new test, was only seen in one job, and failed 1 time(s) against the current commit.
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift High - "[sig-network] Netpol NetworkPolicy between server and client should allow ingress access from namespace on one named port [Feature:NetworkPolicy] [Suite:openshift/conformance/parallel] [Suite:k8s]" is a new test, was only seen in one job, and failed 1 time(s) against the current commit.
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift High - "[sig-network] Netpol NetworkPolicy between server and client should allow ingress access on one named port [Feature:NetworkPolicy] [Suite:openshift/conformance/parallel] [Suite:k8s]" is a new test, was only seen in one job, and failed 1 time(s) against the current commit.

New tests seen in this PR at sha: a867ae1

  • "[sig-network] Netpol NetworkPolicy between server and client should allow egress access on one named port [Feature:NetworkPolicy] [Suite:openshift/conformance/parallel] [Suite:k8s]" [Total: 1, Pass: 0, Fail: 1, Flake: 0]
  • "[sig-network] Netpol NetworkPolicy between server and client should allow ingress access from namespace on one named port [Feature:NetworkPolicy] [Suite:openshift/conformance/parallel] [Suite:k8s]" [Total: 1, Pass: 0, Fail: 1, Flake: 0]
  • "[sig-network] Netpol NetworkPolicy between server and client should allow ingress access on one named port [Feature:NetworkPolicy] [Suite:openshift/conformance/parallel] [Suite:k8s]" [Total: 1, Pass: 0, Fail: 1, Flake: 0]

@RishabhSaini
helpers: Handle Disconnnected Clusters using curl
36da583 
pinnedimages: In metal disconnected case, check for existence prior to
MCN status
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 29, 2025 •
edited by openshift-ci bot
Loading

@RishabhSaini: This pull request references MCO-1722 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

helpers: Handle Disconnnected Clusters using curl
pinnedimages: In metal disconnected case, check for existence prior to
MCN status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 29, 2025 •
edited by openshift-ci bot
Loading

@RishabhSaini: This pull request references MCO-1722 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

helpers: Handle Disconnnected Clusters using curl
pinnedimages: In metal disconnected case, check for existence of images prior to MCN status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@isabella-janssen
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: isabella-janssen, RishabhSaini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 88edc2f and 2 for PR HEAD 36da583 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 30, 2025 •
edited
Loading

@RishabhSaini: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-serial-publicnet-1of2 36da583 link false /test e2e-aws-ovn-serial-publicnet-1of2
ci/prow/e2e-aws-ovn-single-node-upgrade 36da583 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-etcd-scaling 36da583 link false /test e2e-aws-ovn-etcd-scaling
ci/prow/okd-scos-e2e-aws-ovn 36da583 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-vsphere-ovn-etcd-scaling 36da583 link false /test e2e-vsphere-ovn-etcd-scaling
ci/prow/e2e-azure-ovn-upgrade 36da583 link false /test e2e-azure-ovn-upgrade
ci/prow/e2e-metal-ipi-ovn-dualstack-local-gateway 36da583 link false /test e2e-metal-ipi-ovn-dualstack-local-gateway
ci/prow/e2e-aws-disruptive 36da583 link false /test e2e-aws-disruptive
ci/prow/e2e-metal-ipi-serial-ovn-ipv6-2of2 36da583 link false /test e2e-metal-ipi-serial-ovn-ipv6-2of2
ci/prow/e2e-gcp-ovn-etcd-scaling 36da583 link false /test e2e-gcp-ovn-etcd-scaling
ci/prow/e2e-gcp-ovn-rt-upgrade 36da583 link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-aws-ovn-single-node-serial 36da583 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-azure-ovn-etcd-scaling 36da583 link false /test e2e-azure-ovn-etcd-scaling
ci/prow/e2e-gcp-fips-serial-1of2 36da583 link false /test e2e-gcp-fips-serial-1of2
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 36da583 link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/e2e-aws-ovn-kube-apiserver-rollout 36da583 link false /test e2e-aws-ovn-kube-apiserver-rollout
ci/prow/e2e-aws-ovn-single-node 36da583 link false /test e2e-aws-ovn-single-node
ci/prow/okd-e2e-gcp 36da583 link false /test okd-e2e-gcp
ci/prow/e2e-metal-ipi-ovn-dualstack 36da583 link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-gcp-fips-serial-2of2 36da583 link false /test e2e-gcp-fips-serial-2of2
ci/prow/4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback 36da583 link false /test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback
ci/prow/e2e-metal-ipi-virtualmedia 36da583 link false /test e2e-metal-ipi-virtualmedia
ci/prow/e2e-metal-ipi-ovn 36da583 link false /test e2e-metal-ipi-ovn
ci/prow/e2e-gcp-disruptive 36da583 link false /test e2e-gcp-disruptive

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e47a79b and 1 for PR HEAD 36da583 in total

@openshift-trt openshift-trt
Copy link

openshift-trt bot commented May 30, 2025

Job Failure Risk Analysis for sha: 36da583

Job Name Failure Risk
pull-ci-openshift-origin-main-4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback High
operator conditions network
This test has passed 98.93% of 3557 runs on release 4.20 [Overall] in the last week.
pull-ci-openshift-origin-main-e2e-aws-ovn-single-node-serial IncompleteTests
Tests for this run (26) are below the historical average (1602): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-gcp-disruptive Medium
[sig-node] static pods should start after being created
Potential external regression detected for High Risk Test analysis
pull-ci-openshift-origin-main-e2e-gcp-ovn-etcd-scaling High
[sig-architecture] platform pods in ns/openshift-etcd should not exit an excessive amount of times
This test has passed 100.00% of 1 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:rare Network:ovn NetworkStack:ipv4 Owner:eng Platform:gcp SecurityMode:default Topology:ha Upgrade:none] in the last week.
pull-ci-openshift-origin-main-okd-scos-e2e-aws-ovn IncompleteTests
Tests for this run (98) are below the historical average (3118): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@openshift-merge-bot openshift-merge-bot bot merged commit 6c48344 into openshift:main May 31, 2025
35 of 59 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests
This PR has been included in build openshift-enterprise-tests-container-v4.20.0-202505310512.p0.g6c48344.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablintino pablintino pablintino left review comments

@djoshy djoshy Awaiting requested review from djoshy

Assignees

@isabella-janssen isabella-janssen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RishabhSaini @openshift-ci-robot @isabella-janssen @openshift-bot @pablintino