Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPQE-19583: add roxctl into dockerfile #61418

Open
wants to merge 56 commits into
base: master
Choose a base branch
from

Conversation

SeanZhao-redhat
Copy link
Contributor

@SeanZhao-redhat SeanZhao-redhat commented Feb 8, 2025

Add roxctl command into docker image for ACS testing, need add in a separate pr.

Copy link
Contributor

openshift-ci bot commented Feb 8, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 8, 2025
@SeanZhao-redhat SeanZhao-redhat marked this pull request as ready for review February 8, 2025 09:06
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 8, 2025
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@SeanZhao-redhat: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-quay-quay-tests-master-omr-ocp416-images quay/quay-tests presubmit Ci-operator config changed
periodic-ci-quay-quay-tests-master-omr-ocp416-quay-omr-tests-omr-ocp416-disconnected N/A periodic Ci-operator config changed
periodic-ci-quay-quay-tests-master-omr-ocp416-unreleased-quay-omr-tests-omr-ocp416-disconnected-unreleased N/A periodic Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@SeanZhao-redhat
Copy link
Contributor Author

/pj-rehearse auto-ack

@openshift-ci-robot
Copy link
Contributor

@SeanZhao-redhat: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@SeanZhao-redhat
Copy link
Contributor Author

/label tide/merge-method-squash

@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Feb 8, 2025
@SeanZhao-redhat SeanZhao-redhat changed the title add roxctl into dockerfile OCPQE-19583: add roxctl into dockerfile Feb 8, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 8, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 8, 2025

@SeanZhao-redhat: This pull request references OCPQE-19583 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 8, 2025

@SeanZhao-redhat: This pull request references OCPQE-19583 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.19.0" version, but no target version was set.

In response to this:

Add roxctl command into docker image for ACS testing, need add in a separate pr.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@hu-weihua
Copy link

/lgtm

Copy link
Contributor

openshift-ci bot commented Feb 8, 2025

@hu-weihua: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Feb 8, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hu-weihua, SeanZhao-redhat
Once this PR has been reviewed and has the lgtm label, please assign shakyav for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

@SeanZhao-redhat, pj-rehearse: failed to create rehearsal jobs ERROR:

failed waiting for prowjobs to finish: context deadline exceeded

If the problem persists, please contact Test Platform.

Copy link
Contributor

openshift-ci bot commented Feb 8, 2025

@SeanZhao-redhat: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@SeanZhao-redhat
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@SeanZhao-redhat: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. rehearsals-ack Signifies that rehearsal jobs have been acknowledged tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants