fix web rules (#1715)

openshift · Dec 3, 2020 · 251f6f9 · 251f6f9
1 parent 3075030
commit 251f6f9
Show file tree

Hide file tree

Showing 8 changed files with 10 additions and 4 deletions.
diff --git a/lib/rules/web/admin_console/4.2/goto.xyaml b/lib/rules/web/admin_console/4.2/goto.xyaml
@@ -193,6 +193,7 @@ goto_machineconfig_pools_page:
   url: k8s/cluster/machineconfiguration.openshift.io~v1~MachineConfigPool
 goto_machine_sets_page:
   url: k8s/ns/openshift-machine-api/machine.openshift.io~v1beta1~MachineSet
+  action: wait_box_loaded
 goto_machineautoscaler_list_page:
   url: k8s/ns/openshift-machine-api/autoscaling.openshift.io~v1beta1~MachineAutoscaler
 goto_one_machineautoscaler_page:

diff --git a/lib/rules/web/admin_console/4.3/goto.xyaml b/lib/rules/web/admin_console/4.3/goto.xyaml
@@ -232,6 +232,7 @@ goto_machineconfig_pools_page:
   url: k8s/cluster/machineconfiguration.openshift.io~v1~MachineConfigPool
 goto_machine_sets_page:
   url: k8s/ns/openshift-machine-api/machine.openshift.io~v1beta1~MachineSet
+  action: wait_box_loaded
 goto_machineautoscaler_list_page:
   url: k8s/ns/openshift-machine-api/autoscaling.openshift.io~v1beta1~MachineAutoscaler
 goto_one_machineautoscaler_page:

diff --git a/lib/rules/web/admin_console/4.4/goto.xyaml b/lib/rules/web/admin_console/4.4/goto.xyaml
@@ -260,6 +260,7 @@ goto_machineconfig_pools_page:
   url: k8s/cluster/machineconfiguration.openshift.io~v1~MachineConfigPool
 goto_machine_sets_page:
   url: k8s/ns/openshift-machine-api/machine.openshift.io~v1beta1~MachineSet
+  action: wait_box_loaded
 goto_machineautoscaler_list_page:
   url: k8s/ns/openshift-machine-api/autoscaling.openshift.io~v1beta1~MachineAutoscaler
 goto_one_machineautoscaler_page:

diff --git a/lib/rules/web/admin_console/4.5/goto.xyaml b/lib/rules/web/admin_console/4.5/goto.xyaml
@@ -268,6 +268,7 @@ goto_machineconfig_pools_page:
   url: k8s/cluster/machineconfiguration.openshift.io~v1~MachineConfigPool
 goto_machine_sets_page:
   url: k8s/ns/openshift-machine-api/machine.openshift.io~v1beta1~MachineSet
+  action: wait_box_loaded
 goto_machineautoscaler_list_page:
   url: k8s/ns/openshift-machine-api/autoscaling.openshift.io~v1beta1~MachineAutoscaler
 goto_one_machineautoscaler_page:

diff --git a/lib/rules/web/admin_console/4.6/goto.xyaml b/lib/rules/web/admin_console/4.6/goto.xyaml
@@ -290,6 +290,7 @@ goto_machineconfig_pools_page:
   url: k8s/cluster/machineconfiguration.openshift.io~v1~MachineConfigPool
 goto_machine_sets_page:
   url: k8s/ns/openshift-machine-api/machine.openshift.io~v1beta1~MachineSet
+  action: wait_box_loaded
 goto_machineautoscaler_list_page:
   url: k8s/ns/openshift-machine-api/autoscaling.openshift.io~v1beta1~MachineAutoscaler
 goto_one_machineautoscaler_page:

diff --git a/lib/rules/web/admin_console/4.7/common_ui_elements.xyaml b/lib/rules/web/admin_console/4.7/common_ui_elements.xyaml
@@ -765,7 +765,7 @@ wait_table_loaded:
   element:
     selector:
       xpath: //table//tr
-    timeout: 30
+    timeout: 40
 skip_dev_perspective_tour:
   elements:
   - selector:

diff --git a/lib/rules/web/admin_console/4.7/goto.xyaml b/lib/rules/web/admin_console/4.7/goto.xyaml
@@ -295,6 +295,7 @@ goto_machineconfig_pools_page:
   action: wait_box_loaded
 goto_machine_sets_page:
   url: k8s/ns/openshift-machine-api/machine.openshift.io~v1beta1~MachineSet
+  action: wait_box_loaded
 goto_machineautoscaler_list_page:
   url: k8s/ns/openshift-machine-api/autoscaling.openshift.io~v1beta1~MachineAutoscaler
 goto_one_machineautoscaler_page:

diff --git a/lib/rules/web/admin_console/4.7/machine.xyaml b/lib/rules/web/admin_console/4.7/machine.xyaml
@@ -12,12 +12,12 @@ click_machine_tab:
   action: click_tab
 check_desired_count_on_machineset_page:
   params:
-    key: Desired Count
+    key: Desired count
     value: <machine_count>
   action: check_resource_details_key_and_value
 edit_machine_count:
   params:
-    item: Edit Machine Count
+    item: Edit Machine count
   action: click_one_dropdown_action
   action: update_resource_count
 delete_machineset_from_action:
@@ -47,4 +47,4 @@ check_unhealthy_health_check_status:
   action: check_status_text
   action: click_health_status_card
   action: check_health_condition
-  action: check_alert_description  
+  action: check_alert_description