Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ONEOCPDEPL-43: Add support for OSD4 #1652

Merged
merged 5 commits into from
Feb 2, 2021
Merged

ONEOCPDEPL-43: Add support for OSD4 #1652

merged 5 commits into from
Feb 2, 2021

Conversation

apodhrad
Copy link
Contributor

Signed-off-by: Andrej Podhradsky [email protected]

@pruan-rht
Copy link
Member

pruan-rht commented Nov 11, 2020 •
edited
Loading

@apodhrad what does OCM stand for?

@akostadinov
Copy link
Contributor

OpenShift Cluster Manager I guess. I not sure it belongs to IaaSes but having a class for it should be fine. Need to look at it thoroughly. Feel welcome to review as well.

@apodhrad
Copy link
Contributor Author

Yes, Openshift Cluster Manager. The implementation uses a bash script which is built on top of ocm-cli
https://github.com/openshift-online/ocm-cli

@apodhrad
Copy link
Contributor Author

Here is an example of config.yaml

  AWS-INT-QE:
    awscred: config/.awscred-int-qe
    config_opts:
      region: us-east-2
    cloud_type: aws
  ocm:
    token_file: config/.ocm-token-int-qe
    url: https://api.stage.openshift.com
    cloud: AWS-INT-QE
    region: eu-central-1
    flavor: m5.xlarge
    nodes: 4
    lifespan: 36
    cloud_type: ocm

@apodhrad apodhrad force-pushed the ONEOCPDEPL-43 branch 4 times, most recently from 727a291 to e9068f4 Compare December 3, 2020 12:07
akostadinov
akostadinov reviewed Dec 3, 2020
View reviewed changes
lib/launchers/ocm.rb Outdated Show resolved Hide resolved
akostadinov
akostadinov reviewed Dec 3, 2020
View reviewed changes
lib/launchers/ocm.rb Outdated Show resolved Hide resolved
akostadinov
akostadinov reviewed Dec 3, 2020
View reviewed changes
lib/launchers/ocm.rb Outdated Show resolved Hide resolved
akostadinov
akostadinov reviewed Dec 3, 2020
View reviewed changes
lib/launchers/ocm.rb Outdated Show resolved Hide resolved
akostadinov
akostadinov reviewed Dec 3, 2020
View reviewed changes
lib/launchers/ocm.rb Outdated Show resolved Hide resolved
akostadinov
akostadinov reviewed Dec 3, 2020
View reviewed changes
lib/launchers/ocm.rb Outdated Show resolved Hide resolved
@apodhrad apodhrad force-pushed the ONEOCPDEPL-43 branch 2 times, most recently from 07f18c7 to a4be6bd Compare December 3, 2020 16:34
akostadinov
akostadinov reviewed Dec 3, 2020
View reviewed changes
lib/launchers/ocm.rb Outdated Show resolved Hide resolved
@apodhrad apodhrad force-pushed the ONEOCPDEPL-43 branch 7 times, most recently from 3ccb0cb to 6729aee Compare December 7, 2020 16:23
@apodhrad apodhrad force-pushed the ONEOCPDEPL-43 branch 4 times, most recently from c617ea8 to 8df2108 Compare January 14, 2021 14:11
@apodhrad apodhrad force-pushed the ONEOCPDEPL-43 branch 12 times, most recently from 5b22f63 to 08124b7 Compare January 22, 2021 13:30
@akostadinov
Copy link
Contributor

@apodhrad , I have moved stuff a little and fixed downloading by chunks. Let me know if you find any issues with the changes.

@akostadinov akostadinov added the tide/merge-method-merge Denotes a PR that should use a standard merge by tide when it merges. label Jan 23, 2021
@apodhrad
Copy link
Contributor Author

Hi @akostadinov the PR is ready for merge.

@akostadinov
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akostadinov, apodhrad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2021
@openshift-merge-robot openshift-merge-robot merged commit e925932 into openshift:master Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akostadinov akostadinov akostadinov left review comments

@liangxia liangxia Awaiting requested review from liangxia

Assignees

@akostadinov akostadinov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. tide/merge-method-merge Denotes a PR that should use a standard merge by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@apodhrad @pruan-rht @akostadinov @openshift-ci-robot @openshift-merge-robot