typing: Add (more) missing proxy arguments

The Proxy._update method also requires a value argument. Once again, this currently works only because the '_check_resource' decorator is filling in the missing value for us. mypy didn't/couldn't pick this up because of our use of untyped '**attrs' in both the base class and all callers. Another one we'd like to resolve long-term but haven't managed to do yet. Change-Id: I73920092a474744f1d7b154d36bc2af1aeb5eb53 Signed-off-by: Stephen Finucane <[email protected]>
openstack · Feb 26, 2025 · 73a7c8e · 73a7c8e
1 parent 6438e3b
commit 73a7c8e
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 2 deletions.
diff --git a/openstack/compute/v2/_proxy.py b/openstack/compute/v2/_proxy.py
@@ -1988,6 +1988,7 @@ def update_volume_attachment(
 
         return self._update(
             _volume_attachment.VolumeAttachment,
+            None,
             id=volume_id,
             server_id=server_id,
             volume_id=new_volume_id,

diff --git a/openstack/identity/v3/_proxy.py b/openstack/identity/v3/_proxy.py
@@ -329,6 +329,7 @@ def update_domain_config(self, domain, **attrs):
         domain_id = resource.Resource._get_id(domain)
         return self._update(
             _domain_config.DomainConfig,
+            None,
             domain_id=domain_id,
             **attrs,
         )

diff --git a/openstack/image/v2/_proxy.py b/openstack/image/v2/_proxy.py
@@ -1109,6 +1109,7 @@ def update_member(self, member, image, **attrs):
         image_id = resource.Resource._get_id(image)
         return self._update(
             _member.Member,
+            None,
             member_id=member_id,
             image_id=image_id,
             **attrs,

diff --git a/openstack/tests/unit/compute/v2/test_proxy.py b/openstack/tests/unit/compute/v2/test_proxy.py
@@ -644,6 +644,7 @@ def test_volume_attachment_update(self):
             volume_attachment.VolumeAttachment,
             method_args=[],
             method_kwargs={'server': 'server_id', 'volume': 'volume_id'},
+            expected_args=[None],
             expected_kwargs={
                 'id': 'volume_id',
                 'server_id': 'server_id',

diff --git a/openstack/tests/unit/identity/v3/test_proxy.py b/openstack/tests/unit/identity/v3/test_proxy.py
@@ -158,7 +158,7 @@ def test_domain_config_update(self):
             domain_config.DomainConfig,
             method_args=['domain_id'],
             method_kwargs={},
-            expected_args=[],
+            expected_args=[None],
             expected_kwargs={
                 'domain_id': 'domain_id',
             },

diff --git a/openstack/tests/unit/image/v2/test_proxy.py b/openstack/tests/unit/image/v2/test_proxy.py
@@ -623,7 +623,7 @@ def test_member_update(self):
             "openstack.proxy.Proxy._update",
             self.proxy.update_member,
             method_args=['member_id', 'image_id'],
-            expected_args=[_member.Member],
+            expected_args=[_member.Member, None],
             expected_kwargs={'member_id': 'member_id', 'image_id': 'image_id'},
         )