Skip to content

Commit

Permalink
deps: Bump minimum keystoneauth
Browse files Browse the repository at this point in the history
We want typing.

Change-Id: I83cff62f92f942257f178921a6b94d49f25c69c9
Signed-off-by: Stephen Finucane <[email protected]>
  • Loading branch information
stephenfin committed Feb 24, 2025
1 parent b3e1951 commit fbebf10
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ repos:
hooks:
- id: mypy
additional_dependencies:
- keystoneauth1
- keystoneauth1>=5.10.0
- types-decorator
- types-PyYAML
- types-requests
Expand Down
6 changes: 3 additions & 3 deletions openstack/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ def supports_microversion(
f'Required microversion {microversion} is higher than '
f'currently selected {adapter.default_microversion}'
)
return supports # type: ignore[no-any-return]
return supports

return True

Expand Down Expand Up @@ -276,7 +276,7 @@ def pick_microversion(
'Requested microversion is not supported by the server side '
'or the default microversion is too low'
)
return discover.version_to_string(required_normalized) # type: ignore[no-any-return]
return discover.version_to_string(required_normalized)


def maximum_supported_microversion(
Expand Down Expand Up @@ -327,7 +327,7 @@ def maximum_supported_microversion(
return None

result = min(client_max, server_max)
return discover.version_to_string(result) # type: ignore[no-any-return]
return discover.version_to_string(result)


def _hashes_up_to_date(
Expand Down
3 changes: 1 addition & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@ show_error_context = true
ignore_missing_imports = true
follow_imports = "normal"
check_untyped_defs = true
# TODO(stephenfin): Remove this when typed keystoneauth1 (5.10.0?) is released
warn_unused_ignores = false
warn_unused_ignores = true
# many of the following are false while we incrementally add typing
warn_return_any = false
warn_unused_configs = true
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ dogpile.cache>=0.6.5 # BSD
iso8601>=0.1.11 # MIT
jmespath>=0.9.0 # MIT
jsonpatch!=1.20,>=1.16 # BSD
keystoneauth1>=3.18.0 # Apache-2.0
keystoneauth1>=5.10.0 # Apache-2.0
os-service-types>=1.7.0 # Apache-2.0
pbr!=2.1.0,>=2.0.0 # Apache-2.0
platformdirs>=3 # MIT License
Expand Down

0 comments on commit fbebf10

Please sign in to comment.