Reorganize blocks table from status/revoked to begin/end/status columns #4200
+62
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you have a feel for how dependent on #4199 this is? I guess it tends to make the list wider, making that change more important? |
|
Table is going to be wider with longer usernames. When I made #4199 I was planning for one extra column , but I merged it into Status later. |
|
Before: After: Doesn't seem to be wider. |
AntonKhorev
force-pushed
the
blocks-table
branch
3 times, most recently
from
a21a9de
to
3ad717a
Compare
AntonKhorev
force-pushed
the
blocks-table
branch
from
3ad717a
to
14dbb51
Compare
AntonKhorev
added
the
moderation
AntonKhorev
force-pushed
the
blocks-table
branch
from
14dbb51
to
cfaeb38
Compare
AntonKhorev
force-pushed
the
blocks-table
branch
2 times, most recently
from
b257abe
to
7097763
Compare
Could display when block was viewed before. That's going to be unintuitive if sorting by different times is introduced.
AntonKhorev
force-pushed
the
blocks-table
branch
from
7097763
to
156c526
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently blocks tables contain too much repeated text like "Ends in almost 10 years and after the user has logged in." which could be made shorter. Partly such messages can be replaced by the column containing just dates.
The Revoked by column is almost never used. Here I merge it with Status column because revoked block is no longer active.
Start date would be useful to see, especially if sorting by this date is added. This was earlier attempted in #1656.
Fixes #907.