fix(core-browser): accelerator string can only contain ASCII characte…

…rs (#2017)
opensumi · Nov 29, 2022 · 8d0e866 · 8d0e866
1 parent edf4056
commit 8d0e866
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/core-browser/__tests__/keyboard/keyboard-layout-service.test.ts b/packages/core-browser/__tests__/keyboard/keyboard-layout-service.test.ts
@@ -72,10 +72,10 @@ describe('KeyboardLayoutService should be work', () => {
       );
       const disposable = keyboardLayoutService.onKeyboardLayoutChanged(() => {
         const toggleComment = keyboardLayoutService.resolveKeyCode(KeyCode.createKeyCode('Slash+M1'));
-        expect(toggleComment.toString()).toBe(`${isOSX ? '⌘' : 'Ctrl'}+/`);
+        expect(toggleComment.toString()).toBe(`${isOSX ? 'Cmd' : 'Ctrl'}+/`);
         expect(keyboardLayoutService.getKeyboardCharacter(toggleComment.key!)).toBe('/');
         const indentLine = keyboardLayoutService.resolveKeyCode(KeyCode.createKeyCode('BracketRight+M1'));
-        expect(indentLine.toString()).toBe(`${isOSX ? '⌘' : 'Ctrl'}+]`);
+        expect(indentLine.toString()).toBe(`${isOSX ? 'Cmd' : 'Ctrl'}+]`);
         expect(keyboardLayoutService.getKeyboardCharacter(indentLine.key!)).toBe(']');
         disposable.dispose();
         done();

diff --git a/packages/core-browser/src/keyboard/keys.ts b/packages/core-browser/src/keyboard/keys.ts
@@ -160,7 +160,7 @@ export class KeyCode {
   public toString(): string {
     const result: string[] = [];
     if (this.meta) {
-      result.push(isOSX ? '⌘' : 'Win');
+      result.push(isOSX ? 'Cmd' : 'Win');
     }
     if (this.shift) {
       result.push(toNormalCase(Key.SHIFT_LEFT.easyString));