Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: potential null ref when reloading components #4228

Open
wants to merge 2 commits into
base: v3.6
Choose a base branch
from

Conversation

hacke2
Copy link
Member

@hacke2 hacke2 commented Dec 13, 2024

Types

  • 🐛 Bug Fixes

Background or solution

Changelog

@opensumi opensumi bot added the 🐞 bug Something isn't working label Dec 13, 2024
@hacke2 hacke2 requested a review from Ricbet December 13, 2024 07:50
@hacke2
Copy link
Member Author

hacke2 commented Dec 13, 2024

/next

@opensumi
Copy link
Contributor

opensumi bot commented Dec 13, 2024

🎉 PR Next publish successful!

3.6.1-next-1734076438.0

@hacke2
Copy link
Member Author

hacke2 commented Dec 13, 2024

/next

@opensumi
Copy link
Contributor

opensumi bot commented Dec 13, 2024

🎉 PR Next publish successful!

3.6.2-next-1734078245.0

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.06%. Comparing base (ca15b4c) to head (6783acc).

Additional details and impacted files
@@            Coverage Diff             @@
##             v3.6    #4228      +/-   ##
==========================================
- Coverage   54.18%   54.06%   -0.12%     
==========================================
  Files        1616     1616              
  Lines       99701    97965    -1736     
  Branches    20596    20047     -549     
==========================================
- Hits        54021    52964    -1057     
+ Misses      37832    37392     -440     
+ Partials     7848     7609     -239     
Flag Coverage Δ
jsdom 49.64% <ø> (-0.19%) ⬇️
node 15.55% <ø> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant