-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prefunded ETH accounts to localnet chainspec #1116
base: devnet-ready
Are you sure you want to change the base?
Conversation
node/src/chain_spec/localnet.rs
Outdated
@@ -77,6 +77,17 @@ fn localnet_genesis( | |||
get_account_id_from_seed::<sr25519::Public>("Ferdie"), | |||
2000000000000u128, | |||
), | |||
// ETH | |||
( | |||
// Alith |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add the ETH address in the doc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure where should I add it. Alith and Baltathar are easy to find, but I agree it would be good to have it in our docs too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding the address in the comment I think would be helpful
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding the address in the comment I think would be helpful
Done.
node/src/chain_spec/localnet.rs
Outdated
@@ -77,6 +77,17 @@ fn localnet_genesis( | |||
get_account_id_from_seed::<sr25519::Public>("Ferdie"), | |||
2000000000000u128, | |||
), | |||
// ETH | |||
( | |||
// Alith |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding the address in the comment I think would be helpful
Description
Adds two well known ETH accounts, Alith and Baltathar, to
localnet
chainspec.Related Issue(s)
Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
cargo fmt
andcargo clippy
to ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.