add glyph character to the glyph inspector for easier copying #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Connum
requested changes
Mar 10, 2023
| @@ -130,6 +130,7 @@ <h1>Free Software</h1> | |||
| var glyph = font.glyphs.get(glyphIndex), | |||
| html = '<dl>'; | |||
| html += '<dt>name</dt><dd>'+glyph.name+'</dd>'; | |||
| html += '<dt>glyph</dt><dd>'+String.fromCodePoint.apply(null, glyph.unicodes) + '</dd>'; | |||
There was a problem hiding this comment.
When there are multiple code points for a glyph, all characters are just concatenated. A comma separated list would be preferrable. Also "glyph" is not really the correct term as a label here, because it's not the glyph we're showing, but readable characters for codepoints that are matched to that glyph.
|
Hey @manylegged, I would like to get this merged to reduce the number of open PRs. So if you find the time, it would be great if you had a look at my comment. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
I'm trying to copy glyphs from an icon font into source code. Displaying the glyph directly in the web page text makes it easy to load up an icon font and copy the characters I need.
How Has This Been Tested?
I copied glyph-inspector.html and opentype.js onto my own server.
Screenshots (if appropriate):
Types of changes
Checklist:
npm run testand all tests passed green (including code styling checks).