add tests for and fix #613, test toDOMElement() via mocked elements #621
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes #613 which was caused by an if statement that could never be fulfilled, leading to
Path
properties not all making their way to the generated SVG output oftoSVG()
. It also fixes the properties being completely ignored bytoDOMElement()
and allows to test that function in the first place by mockingdocument.createElementNS()
.Motivation and Context
We weren't able to test
toDOMElement()
in Node context before, that's why we missed that the properties were completely ignored. There was also no test case that would have caught the missing property fortoSVG()
.How Has This Been Tested?
npm run test
Screenshots (if appropriate):
Types of changes
Checklist:
npm run test
and all tests passed green (including code styling checks).