Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing hintingtt DEBUGing for esm builds #670

Merged
merged 3 commits into from
Apr 11, 2024
Merged

fixing hintingtt DEBUGing for esm builds #670

merged 3 commits into from
Apr 11, 2024

Conversation

axkibe
Copy link
Contributor

@axkibe axkibe commented Jan 24, 2024

Fixes issue #669

@Connum Connum self-requested a review April 11, 2024 19:36
Connum
Connum approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@Connum Connum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! This was also one of the reasons why the hinting checkbox in the docs/index.html was broken. Now the minified builds don't contain the corresponding code anymore, resulting in a smaller file size as well.

@Connum Connum merged commit 976c723 into opentypejs:master Apr 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Connum Connum Connum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axkibe @Connum