-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement variable font rendering (gvar, avar, hvar, cvar) #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e calculation during interpolation, glyphs with segments not working yet)
… variation options on index.html as well
…n't have a gvar table (CFF2 blend transforms not yet supported)
…of integer in docs
# Conflicts: # docs/index.html # src/font.js # src/util.js
…nt font load failing
…e unicode suite tests pass
…ass more unicode tests
…st suite due to only minor differences in paths
…st suite due to only minor differences in paths
yne
approved these changes
Apr 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd have to do a full look through the code, but from what I can see it looks good. |
This was referenced Apr 20, 2024
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements rendering of variable fonts.
Description
TODOs before this is ready for review:
TODOs for future PRs:
Motivation and Context
Finally, after supporting parsing of the required tables, we can also render glyph variations.
How Has This Been Tested?
Visual testing, comparing coordinates with other implementations, added tests.
Screenshots (if appropriate):
The tests in the unicode test suite regarding the supported tables look fine, only a few are failing due to minor rounding differences. Several unrelated tests have been fixed along the way.
passing: 212, failing: 539)
as opposed topassing: 37, failing: 708
with 1.3.4.Types of changes
Checklist:
npm run test
and all tests passed green (including code styling checks).