You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Consider the variant chr1 99772782 A ATAA on GRCm38. It produces a annotation on transcript ENSMUST00000086738. The short_descriptionis p.7*.
This seems wrong. It should be p.7ins*. The code in PrematureStop.short_description does not handle empty aa_ref, unlike the code in KnownAminoAcidChange.short_description.
Suggestion: move the code from KnownAminoAcidChange.short_description into a function that accepts the arguments aa_ref,aa_alt,aa_mutation_start_offset. Call that function from both KnownAminoAcidChange and PrematureStopwhere the latter appends the stop codon * to aa_alt.
The text was updated successfully, but these errors were encountered:
Consider the variant
chr1 99772782 A ATAA
on GRCm38. It produces a annotation on transcriptENSMUST00000086738
. Theshort_description
isp.7*
.This seems wrong. It should be
p.7ins*
. The code inPrematureStop.short_description
does not handle emptyaa_ref
, unlike the code inKnownAminoAcidChange.short_description
.Suggestion: move the code from
KnownAminoAcidChange.short_description
into a function that accepts the argumentsaa_ref,aa_alt,aa_mutation_start_offset
. Call that function from bothKnownAminoAcidChange
andPrematureStop
where the latter appends the stop codon*
toaa_alt
.The text was updated successfully, but these errors were encountered: