-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cmake scripts for cpplint and clang-format #3440
Open
ivikhrev
wants to merge
16
commits into
openvinotoolkit:master
Choose a base branch
from
ivikhrev:add-style-checkers
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivikhrev
force-pushed
the
add-style-checkers
branch
2 times, most recently
from
April 4, 2022 09:08
f88a479
to
b358c6e
Compare
pre-commit check failed |
ivikhrev
force-pushed
the
add-style-checkers
branch
2 times, most recently
from
April 4, 2022 12:06
3e191e4
to
05266c9
Compare
ivikhrev
force-pushed
the
add-style-checkers
branch
from
April 4, 2022 13:05
cad1e49
to
e243e88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on openvino scripts (https://github.com/openvinotoolkit/openvino/tree/master/cmake/developer_package/clang_format and https://github.com/openvinotoolkit/openvino/tree/master/cmake/developer_package/cpplint).
Now each buildable target has 3 connected targets:
<target_name>_cpplint
,<target_name>_clang,
<target_name>_clang_fix
.By default enabled only
clang-format
checks. When build target withcmake --build
will be triggered correspondingclang_fix
task which automatically apply code style changes. To run onlyclang-format
checks for all targets pass to thecmake --build . --target <target_name>
clang_format_check_all
orclang_format_fix_all
to apply code style fixes.To start
cpplint
checks you should pass tocmake
parameter-DENABLE_CPPLINT=ON
and then build<target_name>_cpplint
for individual targets orcpplint_all
to check all targets.