refactor: Guest library re-organization (Part 1) #1604
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avaneesh-axiom
changed the base branch from
main
to
feat/binding-primitive-libs
Avaneesh-axiom
force-pushed
the
refactor/guest-library-reorg
branch
3 times, most recently
from
807eedc to
3f49069
Compare
Avaneesh-axiom
force-pushed
the
refactor/guest-library-reorg
branch
from
3f49069 to
8f76dcd
Compare
Avaneesh-axiom
force-pushed
the
refactor/guest-library-reorg
branch
4 times, most recently
from
19ae003 to
b5635f2
Compare
Avaneesh-axiom
force-pushed
the
refactor/guest-library-reorg
branch
from
b5635f2 to
1c56817
Compare
This is to avoid conflict with traits impl'd in moduli_declare!
| @@ -26,11 +29,15 @@ To [leverage](./overview.md) compile-time known moduli for performance, you decl | |||
| ```rust | |||
| moduli_declare! { | |||
| Bls12_381Fp { modulus = "0x1a0111ea397fe69a4b1ba7b6434bacd764774b84f38512bf6730d2a0f6b0f6241eabfffeb153ffffb9feffffffffaaab" }, | |||
| Bn254Fp { modulus = "21888242871839275222246405745257275088696311157297823662689037894645226208583" }, | |||
| Bn254Fp { | |||
| modulus = "21888242871839275222246405745257275088696311157297823662689037894645226208583", impl_field = true | |||
There was a problem hiding this comment.
I am not quite a fan of the impl_field field, though I could live with it if we needed it. But I think it might actually be easy inside the proc-macro to just check if the modulus as a big-int is prime, so impl_field could be inferred?
|
|
||
| /// Find the square root of `x` modulo `modulus` with `non_qr` a | ||
| /// quadratic nonresidue of the field. | ||
| pub fn mod_sqrt(x: &BigUint, modulus: &BigUint, non_qr: &BigUint) -> Option<BigUint> { |
There was a problem hiding this comment.
it would be good in the PR desc to note that this is moved from weierstrass_extension
| @@ -40,7 +20,7 @@ pub fn keccak256(input: &[u8]) -> [u8; 32] { | |||
| #[cfg(target_os = "zkvm")] | |||
| #[inline(always)] | |||
| #[no_mangle] | |||
| extern "C" fn native_keccak256(bytes: *const u8, len: usize, output: *mut u8) { | |||
| pub extern "C" fn native_keccak256(bytes: *const u8, len: usize, output: *mut u8) { | |||
There was a problem hiding this comment.
is the pub needed? I just want to make sure it works with a non-pub extern: https://docs.rs/alloy-primitives/latest/src/alloy_primitives/utils/mod.rs.html#166
|
Assuming this was re-opened by accident |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in this repo related to the guest library re-organization have been split into two PRs. This is the first one.
Notes:
mod_sqrtimplementation was moved from the ecc extension to the algebra extensionDepends on #1603