Add vcdm 2.0 model and context #3436
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: PatStLouis <[email protected]>
… date with vcdm 1.1 Signed-off-by: PatStLouis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
ff137
reviewed
Jan 10, 2025
|
@PatStLouis I think it might be wise to get this "basic" support merged and then worry about integration with DIDComm ICv2 and PPv2 in a future PR. |
|
@dbluhm I agree, I want at the minimum for the models not to break, since the didcomm protocols use the vc models |
Signed-off-by: PatStLouis <[email protected]>
…s-cloudagent-python into vcdm-2.0-data-model-support
Signed-off-by: PatStLouis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
…s-cloudagent-python into vcdm-2.0-data-model-support
Signed-off-by: PatStLouis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
|
@dbluhm ready for review |
|
dbluhm
reviewed
Feb 6, 2025
| holder = presentation["holder"] | ||
| did = holder if isinstance(holder, str) else holder["id"] | ||
| async with context.session() as session: | ||
| wallet: BaseWallet | None = session.inject_or(BaseWallet) | ||
| info = await wallet.get_local_did(did) | ||
| key_type = info.key_type.key_type | ||
|
|
||
| if key_type == "ed25519": | ||
| options["proofType"] = "Ed25519Signature2020" | ||
| elif key_type == "bls12381g2": | ||
| options["proofType"] = "BbsBlsSignature2020" | ||
| elif key_type == "p256": | ||
| options["proofType"] = "EcdsaSecp256r1Signature2019" | ||
| options["proofType"] = "Ed25519Signature2020" |
There was a problem hiding this comment.
I don't see why we removed this code; automatically determining the proof type by the key associated with the DID seems like a good idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs issuanceDate validation for vcdm 1.0 (add a current timestamp if absent)
Needs hooking up with didcomm