-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Change pin flow update #1409
base: main
Are you sure you want to change the base?
feat: Change pin flow update #1409
Conversation
19160e0
to
98c3964
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1409 +/- ##
==========================================
- Coverage 55.68% 55.50% -0.19%
==========================================
Files 223 224 +1
Lines 7939 7998 +59
Branches 2221 2243 +22
==========================================
+ Hits 4421 4439 +18
- Misses 3495 3536 +41
Partials 23 23 ☔ View full report in Codecov by Sentry. |
98c3964
to
42ab907
Compare
Signed-off-by: Christian Lippa <[email protected]>
Signed-off-by: Christian Lippa <[email protected]>
Signed-off-by: Christian Lippa <[email protected]>
Signed-off-by: Christian Lippa <[email protected]>
Signed-off-by: Christian Lippa <[email protected]>
4980b42
to
56fbcde
Compare
… valid Signed-off-by: Christian Lippa <[email protected]>
c049944
to
d1116bc
Compare
|
The last portion of the updated flow (feedback indicating that the PIN was successfully changed) may be updated after the pan-can design teams discussion on feedback logic (i.e when to use inline text, modal sheets/slideups, pop-ups, toasts/banners). I would pause merging this PR until discussions are complete. |
I added the |
Summary of Changes
Modified the change pin flow to be spread across three screens. Firstly a screen to enter your old PIN, then second screen to enter a new PIN, and lastly a confirmation page.
Screenshots, videos, or gifs
Breaking change guide
N/A
Related Issues
N/A
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-by
line (we use the DCO GitHub app to enforce this)If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓