Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new OCA branding 1.1 for credential details #1427

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

fc-santos
Copy link
Contributor

@fc-santos fc-santos commented Feb 4, 2025

Summary of Changes

This PR is part 2/2 of the new OCA branding 1.1.

Screenshots, videos, or gifs

Without OCA bundle:
image

With OCA bundle:
image

Breaking change guide

See #1405

Related Issues

N/A

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this)
  • If applicable, screenshots, gifs, or video are included for UI changes
  • If applicable, breaking changes are described above along with how to address them
  • Updated documentation as needed for changed code and new or modified features
  • Added sufficient tests so that overall code coverage is not reduced

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated checks have passed

@fc-santos fc-santos requested a review from a team as a code owner February 4, 2025 18:51
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 79.59184% with 10 lines in your changes missing coverage. Please review.

Project coverage is 55.66%. Comparing base (aff8281) to head (49d235d).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ages/legacy/core/App/screens/CredentialDetails.tsx 68.75% 5 Missing ⚠️
...components/views/CredentialDetailPrimaryHeader.tsx 75.00% 2 Missing and 1 partial ⚠️
...y/core/App/components/views/CredentialCardLogo.tsx 90.90% 1 Missing ⚠️
...mponents/views/CredentialDetailSecondaryHeader.tsx 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1427      +/-   ##
==========================================
+ Coverage   55.52%   55.66%   +0.13%     
==========================================
  Files         223      227       +4     
  Lines        7985     8081      +96     
  Branches     2241     2300      +59     
==========================================
+ Hits         4434     4498      +64     
- Misses       3528     3558      +30     
- Partials       23       25       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swcurran
Copy link
Contributor

swcurran commented Feb 5, 2025

@fc-santos — please update the PR to get the latest from the base branch. Thanks!

@fc-santos
Copy link
Contributor Author

fc-santos commented Feb 7, 2025

@swcurran I've rebased with main.

Signed-off-by: fc-santos <[email protected]>
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants