-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new OCA branding 1.1 for credential details #1427
base: main
Are you sure you want to change the base?
feat: add new OCA branding 1.1 for credential details #1427
Conversation
Signed-off-by: fc-santos <[email protected]>
Signed-off-by: fc-santos <[email protected]>
Signed-off-by: fc-santos <[email protected]>
Signed-off-by: fc-santos <[email protected]>
Signed-off-by: fc-santos <[email protected]>
Signed-off-by: fc-santos <[email protected]>
Signed-off-by: fc-santos <[email protected]>
Signed-off-by: fc-santos <[email protected]>
Signed-off-by: fc-santos <[email protected]>
Signed-off-by: fc-santos <[email protected]>
Signed-off-by: fc-santos <[email protected]>
…al card Signed-off-by: fc-santos <[email protected]>
Signed-off-by: fc-santos <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1427 +/- ##
==========================================
+ Coverage 55.52% 55.66% +0.13%
==========================================
Files 223 227 +4
Lines 7985 8081 +96
Branches 2241 2300 +59
==========================================
+ Hits 4434 4498 +64
- Misses 3528 3558 +30
- Partials 23 25 +2 ☔ View full report in Codecov by Sentry. |
@fc-santos — please update the PR to get the latest from the base branch. Thanks! |
Signed-off-by: fc-santos <[email protected]>
Signed-off-by: fc-santos <[email protected]>
Signed-off-by: fc-santos <[email protected]>
@swcurran I've rebased with main. |
Signed-off-by: fc-santos <[email protected]>
|
Summary of Changes
This PR is part 2/2 of the new OCA branding 1.1.
Screenshots, videos, or gifs
Without OCA bundle:
![image](https://private-user-images.githubusercontent.com/48060475/410086036-bb53bb0f-9396-4518-8fa1-9453eb4b4ff5.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxOTAwNTMsIm5iZiI6MTczOTE4OTc1MywicGF0aCI6Ii80ODA2MDQ3NS80MTAwODYwMzYtYmI1M2JiMGYtOTM5Ni00NTE4LThmYTEtOTQ1M2ViNGI0ZmY1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEwVDEyMTU1M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWI1Njc1MjhhNjZjMjc0MGRiNGZhZjVjMjYzZjMxMTFmODEwMmI3ODkyNTM1YTk1Yjk1NzhjODMxYWRmMDY4N2ImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.2ndg15t4P4W9N6mBiVXby8bxW9wr6nsSs-SPt5uKbvE)
With OCA bundle:
![image](https://private-user-images.githubusercontent.com/48060475/410085653-2506f7f7-154a-4900-b51a-395d2ad55545.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxOTAwNTMsIm5iZiI6MTczOTE4OTc1MywicGF0aCI6Ii80ODA2MDQ3NS80MTAwODU2NTMtMjUwNmY3ZjctMTU0YS00OTAwLWI1MWEtMzk1ZDJhZDU1NTQ1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEwVDEyMTU1M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTRhZWQ5M2FlMzYyNTFlMWEwNGE1ZTE2ZjgwZjY3OTU1NDc0NmEwYjVkOTIwZjUwYTFmYTU3NzlhNzZiNjFlOWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.9F08Crh_ciT-KGr-5W2_wYRqV12isP-nD9ll_Bxjmjg)
Breaking change guide
See #1405
Related Issues
N/A
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-by
line (we use the DCO GitHub app to enforce this)If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓