-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: disable elements below modal tour on Android #1432
Draft
ClaudeArs
wants to merge
7
commits into
openwallet-foundation:main
Choose a base branch
from
MCN-ING:fix/Disable-elements-below-modalTour
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
fix: disable elements below modal tour on Android #1432
ClaudeArs
wants to merge
7
commits into
openwallet-foundation:main
from
MCN-ING:fix/Disable-elements-below-modalTour
+140
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ClaudeArs <[email protected]>
Signed-off-by: ClaudeArs <[email protected]>
Signed-off-by: ClaudeArs <[email protected]>
fc-santos
reviewed
Feb 7, 2025
@@ -67,6 +66,8 @@ const CredentialOffer: React.FC<CredentialOfferProps> = ({ navigation, credentia | |||
const [buttonsVisible, setButtonsVisible] = useState(true) | |||
const [acceptModalVisible, setAcceptModalVisible] = useState(false) | |||
const [declineModalVisible, setDeclineModalVisible] = useState(false) | |||
const [hideElements, setHideElements] = useState('auto') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could create a type of this variable to be more concise:
import { AccessibilityProps } from 'react-native'
type ImportantForAccessibility = AccessibilityProps['importantForAccessibility']
const [hideElements, setHideElements] = useState<ImportantForAccessibility>('auto')
Since this type will be used in the other screens, maybe add the definition inside the types folder.
Signed-off-by: ClaudeArs <[email protected]>
Signed-off-by: ClaudeArs <[email protected]>
Signed-off-by: ClaudeArs <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Disable elements below modal tour for TalkBack
Screenshots, videos, or gifs
N/A
Breaking change guide
N/A
Related Issues
N/A
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-by
line (we use the DCO GitHub app to enforce this)If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓