Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable elements below modal tour on Android #1432

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ClaudeArs
Copy link
Contributor

Summary of Changes

Disable elements below modal tour for TalkBack

Screenshots, videos, or gifs

N/A

Breaking change guide

N/A

Related Issues

N/A

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this)
  • If applicable, screenshots, gifs, or video are included for UI changes
  • If applicable, breaking changes are described above along with how to address them
  • Updated documentation as needed for changed code and new or modified features
  • Added sufficient tests so that overall code coverage is not reduced

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated checks have passed

@ClaudeArs ClaudeArs requested a review from a team as a code owner February 7, 2025 14:55
@fc-santos fc-santos marked this pull request as draft February 7, 2025 14:58
@@ -67,6 +66,8 @@ const CredentialOffer: React.FC<CredentialOfferProps> = ({ navigation, credentia
const [buttonsVisible, setButtonsVisible] = useState(true)
const [acceptModalVisible, setAcceptModalVisible] = useState(false)
const [declineModalVisible, setDeclineModalVisible] = useState(false)
const [hideElements, setHideElements] = useState('auto')
Copy link
Contributor

@fc-santos fc-santos Feb 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could create a type of this variable to be more concise:

import { AccessibilityProps } from 'react-native'

type ImportantForAccessibility = AccessibilityProps['importantForAccessibility']

const [hideElements, setHideElements] = useState<ImportantForAccessibility>('auto')

Since this type will be used in the other screens, maybe add the definition inside the types folder.

@fc-santos fc-santos changed the title Fix/disable elements below modal tour fix: disable elements below modal tour on Android Feb 7, 2025
Copy link

sonarqubecloud bot commented Feb 7, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
3.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants